docs: update JSDoc for req.host getter #6133
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed the return type annotation to include `undefined`, reflecting the actual return value. - Updated the implementation to use modern JavaScript methods for better readability and performance. - Clarified comments regarding the handling of the X-Forwarded-Host header.
wesleytodd
requested changes
Jan 15, 2025
| @@ -418,6 +418,7 @@ defineGetter(req, 'host', function host(){ | |||
| return val || undefined; | |||
| }); | |||
|
|
|||
|
|
|||
| defineGetter(req, 'host', function host(){ | ||
| var trust = this.app.get('trust proxy fn'); | ||
| var val = this.get('X-Forwarded-Host'); | ||
| defineGetter(req, 'host', function() { |
There was a problem hiding this comment.
Suggested change
| defineGetter(req, 'host', function() { | |
| defineGetter(req, 'host', function host () { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
undefined, reflecting the actual return value.