Refactor: Simplify req.xhr getter by removing redundant function name
#6132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function name `xhr` was removed as it is clear from the property definition. This change improves readability and follows best practices for concise function expressions.
wesleytodd
requested changes
Jan 15, 2025
There was a problem hiding this comment.
Honestly I am getting to the point of just closing these out of principal. I have spent hours opening them and replying. I wont, because I understand this is being done with some positive intent, but wow it is amazing how much time these have sucked out of my life.
This one gets my 👎 because it is style only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function name
xhrwas removed as it is clear from the property definition. This change improves readability and follows best practices for concise function expressions.