refactor: normalize common options for all parsers #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonchurch
requested changes
Feb 17, 2025
Phillip9587
force-pushed
the
normalize-options
branch
from
a03daf7 to
3f6cd01
Compare
|
@jonchurch I've made the requested changes. I think we should merge this first as foundational work for #22, so that when we start on it, the necessary changes are already in place and the scope remains smaller. Let me know what you think! |
Phillip9587
force-pushed
the
normalize-options
branch
3 times, most recently
from
ee6ba4c to
b760930
Compare
bjohansebas
reviewed
Feb 18, 2025
bjohansebas
reviewed
Feb 18, 2025
Phillip9587
force-pushed
the
normalize-options
branch
from
b760930 to
d93b76d
Compare
ctcpip
reviewed
Feb 19, 2025
lib/utils.js
Outdated
Comment on lines
1
to
7
| /*! | ||
| * body-parser | ||
| * Copyright(c) Express Contributors | ||
| * MIT Licensed | ||
| */ | ||
|
|
||
| 'use strict' |
There was a problem hiding this comment.
Suggested change
| /*! | |
| * body-parser | |
| * Copyright(c) Express Contributors | |
| * MIT Licensed | |
| */ | |
| 'use strict' | |
| 'use strict' |
files should not get copyright headers
jonchurch
requested changes
Feb 19, 2025
jonchurch
requested changes
Feb 19, 2025
jonchurch
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #550
This PR introduces the
normalizeOptionsfunction, which standardizes and validates common parser options likeinflate,limit,type, andverify. It ensures consistent defaults and removes duplication across the parsers.