DO NOT MERGE Basic cli 19, snake case #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We can hold this PR until we get some additional breaking changes in, I mainly wanted to verify that everything still worked with basic-cli 0.18. |
|
@isaacvando with that said it is probably best to wait with a review |
|
|
Tests will pass once roc-lang/roc#7548 is in TESTING |
isaacvando
reviewed
Jan 26, 2025
isaacvando
reviewed
Jan 26, 2025
isaacvando
approved these changes
Jan 26, 2025
|
I opened a PR to upgrade the test runner aswell exercism/roc-test-runner#22 |
Anton-4
changed the title
|
@isaacvando Should this be merged before or after exercism/roc-test-runner#22 is merged or does it not matter? |
|
@Anton-4 Unfortunately we don't have a good way to do a non-breaking change right now so we should merge both PRs at the same time to minimize the amount of time the track is broken. |
Anton-4
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.