Matrix: Ensure whole matrix is correct #2199
Conversation
There are some proposed solutions where the mentee submit solution that would emit extra empty rows. For instance with an off by one error in a for-loop. By checking that the whole matrix is exactly as expected we can catch such mistakes.
|
Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed. That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
|
@exercism/reviewers please :) |
|
Link back to Forum discussions for continuity: https://forum.exercism.org/t/pull-requrest-on-exercism-javascript/3440/8 |
|
The new tests take different inputs, so it seems like they should have different property names. |
Good catch, should I just remove the |
There are some proposed solutions where the mentee submit solution that would emit extra empty rows. For instance with an off by one error in a for-loop.
By checking that the whole matrix is exactly as expected we can catch such mistakes.
(Re-open of #2195, cc @SleeplessByte)