Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add junit-platform-launcher to test runtime #2905

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kahgoh
Copy link
Member

@kahgoh kahgoh commented Jan 16, 2025

This is fix the following warning about using deprecated Gradle features:

The automatic loading of test framework implementation dependencies
has been deprecated. This is scheduled to be removed in Gradle 9.0.
Declare the desired test framework directly on the test suite or
explicitly declare the test framework implementation dependencies on
the test's runtime classpath. Consult the upgrading guide for
further information:
https://docs.gradle.org/8.7/userguide/upgrading_version_8.html#test_framework_implementation_dependencies

pull request

The deprecation warning was mentioned in the forums https://forum.exercism.org/t/deprecated-gradle-features-warning-in-the-java-track/14906


Reviewer Resources:

Track Policies

Copy link
Contributor

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

This is fix the following warning about using deprecated Gradle
features:

  The automatic loading of test framework implementation dependencies
  has been deprecated. This is scheduled to be removed in Gradle 9.0.
  Declare the desired test framework directly on the test suite or
  explicitly declare the test framework implementation dependencies on
  the test's runtime classpath. Consult the upgrading guide for
  further information:
  https://docs.gradle.org/8.7/userguide/upgrading_version_8.html#test_framework_implementation_dependencies
@kahgoh kahgoh force-pushed the fix/deprecated-gradle branch from f42c459 to b03dec4 Compare January 16, 2025 14:43
@kahgoh
Copy link
Member Author

kahgoh commented Jan 16, 2025

When merging, I think we can add the [no important files changed] because this doesn't really change the nature of the tests.

@kahgoh
Copy link
Member Author

kahgoh commented Jan 16, 2025

@manumafe98, could you please review this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant