Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating tests for SGF-Parsing #2902

Merged
merged 7 commits into from
Jan 28, 2025

Conversation

jagdish-15
Copy link
Contributor

Pull Request

Hello @kahgoh,

This PR introduces 11 new tests for the sfg-parsing exercise to align it with the problem-specification repository.

However, I encountered difficulties with getting the example solution to work, despite spending several hours trying different approaches. Please let me know how you would like me to proceed from here.


Reviewer Resources:

Track Policies

@jagdish-15 jagdish-15 changed the title Updating tests for SGF-Testing Updating tests for SGF-Parsing Jan 5, 2025
@kahgoh
Copy link
Member

kahgoh commented Jan 18, 2025

Hey @jagdish-15, I'll try to take a look at the example solution over upcoming week.

@kahgoh
Copy link
Member

kahgoh commented Jan 28, 2025

Hey @jagdish-15, I managed to get something working. If I'm not mistaken, I think there is are too many \ characters in the withinPropertyValueWhitespace test (I think this is the "within property values, whitespace characters such as tab are converted to spaces" test case from the problem spec?). I couldn't quite see what you tried with the example solution, but if needed, I got something working by adding some more state to track while parsing.

@jagdish-15
Copy link
Contributor Author

Thank you so much, @kahgoh, for guiding me through this! I apologize for the oversight—there must have been a mistake on my part while copying data from the problem specification repository. I likely copied it directly from the terminal when the configlet printed the tests before updating, and some discrepancy must have occurred during that process. That aside, I’m happy to report that all tests are now passing after your changes to the reference solution!

@kahgoh kahgoh merged commit 0bb6ea4 into exercism:main Jan 28, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants