Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Housekeeping; expose consensus type (closes #679) #820

Merged
merged 2 commits into from
Aug 2, 2023

Conversation

SamWilsn
Copy link
Collaborator

@SamWilsn SamWilsn commented Aug 1, 2023

What was wrong?

Related to Issue #679

How was it fixed?

Added a property to Hardfork that returns the style of consensus for a fork.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 69.23% and project coverage change: -0.01% ⚠️

Comparison is base (c44b1b5) 74.06% compared to head (284879a) 74.06%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #820      +/-   ##
==========================================
- Coverage   74.06%   74.06%   -0.01%     
==========================================
  Files         571      571              
  Lines       31726    31735       +9     
==========================================
+ Hits        23498    23503       +5     
- Misses       8228     8232       +4     
Flag Coverage Δ
unittests 74.06% <69.23%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/ethereum/fork_criteria.py 72.00% <69.23%> (-3.61%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@petertdavies petertdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SamWilsn SamWilsn merged commit 2d873d9 into ethereum:master Aug 2, 2023
4 checks passed
@SamWilsn SamWilsn deleted the pow branch August 2, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants