Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(CHANGELOG): add release date of etcd v3.5.18 #19266

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

ghouscht
Copy link
Member

@ghouscht ghouscht commented Jan 24, 2025

Issue #19119

@ghouscht ghouscht self-assigned this Jan 24, 2025
@ghouscht ghouscht requested review from ivanvc and jmhbnz January 24, 2025 19:43
@ivanvc
Copy link
Member

ivanvc commented Jan 24, 2025

Link to #19119

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @ghouscht.

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.75%. Comparing base (2ee7e34) to head (05e5aad).
Report is 2 commits behind head on main.

Additional details and impacted files

see 16 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19266      +/-   ##
==========================================
- Coverage   68.77%   68.75%   -0.03%     
==========================================
  Files         420      420              
  Lines       35677    35677              
==========================================
- Hits        24538    24530       -8     
- Misses       9714     9721       +7     
- Partials     1425     1426       +1     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ee7e34...05e5aad. Read the comment docs.

@ivanvc
Copy link
Member

ivanvc commented Jan 24, 2025

/retest

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @ghouscht

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ghouscht, ivanvc, jmhbnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jmhbnz jmhbnz merged commit 65a1722 into etcd-io:main Jan 24, 2025
35 checks passed
@ghouscht ghouscht deleted the changelog-release-3.5.18 branch January 24, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants