-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate to use warning-apply-duration flag #19264
Conversation
Hi @gangli113. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
9683109
to
d1e6d0c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 21 files with indirect coverage changes @@ Coverage Diff @@
## main #19264 +/- ##
==========================================
- Coverage 68.86% 68.77% -0.10%
==========================================
Files 420 420
Lines 35681 35677 -4
==========================================
- Hits 24571 24536 -35
- Misses 9689 9715 +26
- Partials 1421 1426 +5 Continue to review full report in Codecov by Sentry.
|
/ok-to-test |
Signed-off-by: Gang Li <[email protected]>
d1e6d0c
to
7f1d3b0
Compare
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please feel free to resolve the nit in a separate PR.
Thank you.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, gangli113 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Migrate flag warning-apply-duration described in: #19141
The experimental flags are marked as deprecated and will be decommissioned in v3.7.