Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate to use warning-apply-duration flag #19264

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

gangli113
Copy link
Contributor

Migrate flag warning-apply-duration described in: #19141

The experimental flags are marked as deprecated and will be decommissioned in v3.7.

@k8s-ci-robot
Copy link

Hi @gangli113. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gangli113
Copy link
Contributor Author

/cc @siyuanfoundation @serathius @ahrtr

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.77%. Comparing base (b16b8dc) to head (7f1d3b0).
Report is 6 commits behind head on main.

Additional details and impacted files
Files with missing lines Coverage Δ
server/embed/config.go 79.56% <100.00%> (+0.03%) ⬆️
server/embed/etcd.go 76.49% <100.00%> (ø)
server/etcdmain/config.go 72.50% <100.00%> (+0.34%) ⬆️

... and 21 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19264      +/-   ##
==========================================
- Coverage   68.86%   68.77%   -0.10%     
==========================================
  Files         420      420              
  Lines       35681    35677       -4     
==========================================
- Hits        24571    24536      -35     
- Misses       9689     9715      +26     
- Partials     1421     1426       +5     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b16b8dc...7f1d3b0. Read the comment docs.

@ahrtr
Copy link
Member

ahrtr commented Jan 24, 2025

/ok-to-test

@siyuanfoundation
Copy link
Contributor

/lgtm

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Please feel free to resolve the nit in a separate PR.

Thank you.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, gangli113

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 2ee7e34 into etcd-io:main Jan 24, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants