Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.4] Update version to 1.4.0 #895

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Feb 7, 2025

Forgot to update the version when releasing v1.4.0. It shouldn't be a big problem, as we don't intentionally release the bbolt binary.

cc @Elbehery @fuweid @ivanvc @serathius

Signed-off-by: Benjamin Wang <[email protected]>
@ahrtr ahrtr changed the title Update version to 1.4.0 [1.4] Update version to 1.4.0 Feb 7, 2025
@ahrtr
Copy link
Member Author

ahrtr commented Feb 7, 2025

@ivanvc probably we can have a script do it automatically?

  • update the version in version.go
  • signoff & commit the change, and push it to github.com
  • create the tag
  • push the tag to github

@ahrtr
Copy link
Member Author

ahrtr commented Feb 7, 2025

probably we can have a script do it automatically?

Raised an issue to track it
#896

@Elbehery
Copy link
Member

Elbehery commented Feb 7, 2025

@ivanvc probably we can have a script do it automatically?

  • update the version in version.go
  • signoff & commit the change, and push it to github.com
  • create the tag
  • push the tag to github

I can work on this 👍🏽

Shall I assign myself ?

@ahrtr
Copy link
Member Author

ahrtr commented Feb 7, 2025

I can work on this 👍🏽

Shall I assign myself ?

OK, thx

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, fuweid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit f61dee2 into etcd-io:release-1.4 Feb 7, 2025
14 checks passed
@ahrtr ahrtr deleted the version_20250207 branch February 7, 2025 13:26
@ivanvc
Copy link
Member

ivanvc commented Feb 7, 2025

Hi @Elbehery and @ahrtr. Given the size of this project, goreleaser may be a good fit. Refer to etcd-io/auger#136.

@ahrtr
Copy link
Member Author

ahrtr commented Feb 7, 2025

Hi @Elbehery and @ahrtr. Given the size of this project, goreleaser may be a good fit. Refer to etcd-io/auger#136.

It seems not resolving the painpoint here. What we want to resolve is to prevent from forgetting to update version next time. A simple lightweight script is good enough.

@ivanvc
Copy link
Member

ivanvc commented Feb 7, 2025

You're right. In this case, we want to update the version before pushing the tag.

And given this project is a library, it doesn't make sense to read the version from a git reference. We want the version to be hardcoded in that file.

@Elbehery
Copy link
Member

Elbehery commented Feb 7, 2025

ok, so we go with bash script ?

@ahrtr
Copy link
Member Author

ahrtr commented Feb 7, 2025

ok, so we go with bash script ?

Yes, please refer to https://github.com/etcd-io/etcd/blob/main/scripts/release.sh. But this one will be much simpler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants