-
Notifications
You must be signed in to change notification settings - Fork 656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.4] Update version to 1.4.0 #895
Conversation
Signed-off-by: Benjamin Wang <[email protected]>
@ivanvc probably we can have a script do it automatically?
|
Raised an issue to track it |
I can work on this 👍🏽 Shall I assign myself ? |
OK, thx |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, fuweid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @Elbehery and @ahrtr. Given the size of this project, goreleaser may be a good fit. Refer to etcd-io/auger#136. |
It seems not resolving the painpoint here. What we want to resolve is to prevent from forgetting to update version next time. A simple lightweight script is good enough. |
You're right. In this case, we want to update the version before pushing the tag. And given this project is a library, it doesn't make sense to read the version from a git reference. We want the version to be hardcoded in that file. |
ok, so we go with bash script ? |
Yes, please refer to https://github.com/etcd-io/etcd/blob/main/scripts/release.sh. But this one will be much simpler. |
Forgot to update the version when releasing v1.4.0. It shouldn't be a big problem, as we don't intentionally release the bbolt binary.
cc @Elbehery @fuweid @ivanvc @serathius