FIX: render form fields have switch condition for theme (mautic#13779)

* Reverse condition If conditional form is rendered, theme modified templates did not used. It seems because condition here is in opposite * Correct loading of a theme with template having precedence --------- Co-authored-by: John Linhart <[email protected]> Co-authored-by: John Linhart <[email protected]>
escopecz · Jun 6, 2024 · e8d5b6c · e8d5b6c
1 parent 5bf1b10
commit e8d5b6c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 18 deletions.
diff --git a/app/bundles/FormBundle/Resources/views/Builder/form.html.twig b/app/bundles/FormBundle/Resources/views/Builder/form.html.twig
@@ -100,22 +100,8 @@
                       {%- set template = '@MauticForm/Field/' ~ f.type ~ '.html.twig' -%}
                   {%- endif -%}
 
-
                   <!-- start: "{{ theme }}{{ template }}" -->
-                  {%- if theme is empty -%}
-                  {{- include(theme ~ f.type ~ '.html.twig', {
-                          'field': f.convertToArray,
-                          'id': f.alias,
-                          'formName': formName,
-                          'fieldPage': (pageCount - 1),
-                          'mappedFields': mappedFields,
-                          'inBuilder': inBuilder,
-                          'fields': fields,
-                          'language': form.getLanguage()
-
-                  }) -}}
-                  {%- else -%}
-                  {{- include(template, {
+                  {{- include([theme ~ f.type ~ '.html.twig', template], {
                           'field': f.convertToArray,
                           'id': f.alias,
                           'formName': formName,
@@ -124,9 +110,7 @@
                           'inBuilder': inBuilder,
                           'fields': fields,
                           'language': form.getLanguage()
-
                   }) -}}
-                {%- endif -%}
                   <!-- end: "{{ theme }}{{ template }}" -->
                 {%- endif -%}
               {%- endfor -%}

diff --git a/app/bundles/FormBundle/Tests/Controller/Api/FormApiControllerFunctionalTest.php b/app/bundles/FormBundle/Tests/Controller/Api/FormApiControllerFunctionalTest.php
@@ -156,7 +156,10 @@ public function testSingleFormWorkflow(): void
         $this->client->request(Request::METHOD_POST, '/api/forms/new', $payload);
         $clientResponse = $this->client->getResponse();
         $response       = json_decode($clientResponse->getContent(), true);
-        $formId         = $response['form']['id'];
+
+        Assert::assertTrue(isset($response['form']['id']), $clientResponse->getContent());
+
+        $formId = $response['form']['id'];
 
         $this->assertSame(Response::HTTP_CREATED, $clientResponse->getStatusCode(), $clientResponse->getContent());
         $this->assertGreaterThan(0, $formId);