Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if PKCE is supported when exchanging token #399

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Check if PKCE is supported when exchanging token #399

merged 1 commit into from
Nov 13, 2024
+92 −23

Conversation

maennchen
Copy link
Member

Fixes #398

@maennchen maennchen added the bug label Nov 12, 2024
@maennchen maennchen self-assigned this Nov 12, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 234

Details

  • 11 of 13 (84.62%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 91.873%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/oidcc_token.erl 11 13 84.62%
Files with Coverage Reduction New Missed Lines %
src/oidcc_provider_configuration_worker.erl 1 95.35%
Totals Coverage Status
Change from base Build 217: -0.1%
Covered Lines: 1074
Relevant Lines: 1169
💛 - Coveralls

@chgeuer
Copy link

chgeuer commented Nov 13, 2024

Works on my solution, thanks a lot.

@maennchen maennchen merged commit 7a9e523 into main Nov 13, 2024
26 checks passed
@maennchen maennchen deleted the token_pkce_check branch November 13, 2024 09:03
@maennchen maennchen mentioned this pull request Nov 14, 2024
Open
@logandk
Copy link

logandk commented Nov 14, 2024

Just encountered the same issue today, this commit fixed the non-PKCE authentication flow in our case as well. Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@maennchen maennchen

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maennchen @coveralls @chgeuer @logandk