Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update elixir tool version #387

Closed
wants to merge 1 commit into from

Conversation

dustinfarris
Copy link
Contributor

@dustinfarris dustinfarris commented Oct 23, 2024

The default 1.17.2 version from hex is built with OTP 25. mix test has a failure with this version.

  1) test &Oidcc.client_credentials_token/2 works (Oidcc.TokenTest)
     test/oidcc/token_test.exs:211
     match (=) failed
     code:  assert {:ok, %Token{}} =
              Oidcc.Token.client_credentials(
                client_context,
                %{scope: ["openid"]}
              )
     left:  {:ok, %Oidcc.Token{}}
     right: {:error, :no_matching_key}
     stacktrace:
       test/oidcc/token_test.exs:224: (test)

Updating to the OTP 27 build resolves this issue.

The 1.17.2 version from asdf is built with OTP 25.  `mix test` has a
failure with this version.  Updating to the OTP 27 build resolves this
issue.
@maennchen
Copy link
Member

@dustinfarris It seems unlikely, that this test is broken by that. Are you sure it’s not just flaky?

@dustinfarris
Copy link
Contributor Author

@dustinfarris It seems unlikely, that this test is broken by that. Are you sure it’s not just flaky?

You are correct. It is flaky.

@dustinfarris dustinfarris deleted the bump-tools branch October 23, 2024 20:43
@maennchen
Copy link
Member

@dustinfarris Can you open an issue about the test? We shouldn’t have flaky tests either…

@dustinfarris
Copy link
Contributor Author

@dustinfarris Can you open an issue about the test? We shouldn’t have flaky tests either…

#389

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants