Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix API call in yrno() function #462

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

jackdeye
Copy link

Updated how jsonparser parses the degree and condition from the API call. This is fixing the issue brought up in #457.

Updated how jsonparser parses the degree and condition from the API
call.
@erikw
Copy link
Owner

erikw commented Feb 12, 2025

Thank you so much!

Just fix the linter suggestions. I copied and pasted the relevant log lines for you here:

In /github/workspace/segments/weather.sh line 100:
degree=$(echo "$weather_data" | $jsonparser -r .properties.timeseries | .[0].data.instant.details.air_temperature)
^-- SC2211 (warning): This is a glob used as a command name. Was it supposed to be in ${..}, array, or is it missing quoting?

In /github/workspace/segments/weather.sh line 101:
condition=$(echo "$weather_data" | $jsonparser -r .properties.timeseries | .[0].data.next_1_hours.summary.symbol_code)
^-- SC2211 (warning): This is a glob used as a command name. Was it supposed to be in ${..}, array, or is it missing quoting?

For more information:
https://www.shellcheck.net/wiki/SC2211 -- This is a glob used as a command ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants