make proto configurable #748
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zirain <[email protected]>
zirain
force-pushed
the
make-proto-configurable
branch
from
6037635
to
00e75e6
Compare
This was referenced Oct 28, 2024
zhaohuabing
reviewed
Nov 1, 2024
| @@ -11,6 +11,7 @@ import ( | |||
| ) | |||
|
|
|||
| type Settings struct { | |||
| Proto string `envconfig:"PROTO" default:"tcp"` | |||
There was a problem hiding this comment.
Nit: how about using Protocol instead of Proto? In our context, Proto could be mistaken with ProtoBuf.
There was a problem hiding this comment.
Or maybe a more straighforward DualStack or EnableIPV6 ?
There was a problem hiding this comment.
this align to reuseport.Listen(proto, addr string) (l net.Listener, err error)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make
Protoconfigurable cause I want to use the combination ofreuseport.Listen(“tcp6”, “:8881"), that will listen on[::]:8881and you can access it with[::]:8881and127.0.0.1:8881IMO, this more like a bug from reuseport package? Because I think
reuseport.Listen(“tcp”, “:8881")should be the right way to do this, but it's hard to change a package which isn't updated for three years.