Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect analytics mapping for UTDs. #3497

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Nov 7, 2024

As pointed out by @BillCarsonFr, #3442 messed up the mapping here.

Additionally upgrades the CI runners to macOS 15 given the failure in https://github.com/element-hq/element-x-ios/actions/runs/11727089995/job/3266732078, caused by actions/runner-images#10703.

@pixlwave pixlwave requested a review from a team as a code owner November 7, 2024 16:22
@pixlwave pixlwave requested review from stefanceriu and removed request for a team November 7, 2024 16:22
@pixlwave pixlwave added the pr-misc for other changes label Nov 7, 2024
Copy link

github-actions bot commented Nov 7, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against fda78a8

Copy link

sonarcloud bot commented Nov 7, 2024

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.60%. Comparing base (4f8565c) to head (fda78a8).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
.../FlowCoordinators/UserSessionFlowCoordinator.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3497      +/-   ##
===========================================
+ Coverage    78.56%   78.60%   +0.04%     
===========================================
  Files          743      743              
  Lines        61607    61607              
===========================================
+ Hits         48400    48426      +26     
+ Misses       13207    13181      -26     
Flag Coverage Δ
unittests 69.36% <0.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pixlwave pixlwave merged commit 4e880f1 into develop Nov 8, 2024
11 checks passed
@pixlwave pixlwave deleted the doug/fix-utd-analytics branch November 8, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-misc for other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants