Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [32-x-y] cherry-pick 1 changes from 1-M133 #45719

Open
wants to merge 2 commits into
base: 32-x-y
Choose a base branch
from

Conversation

ppontes
Copy link
Member

@ppontes ppontes commented Feb 19, 2025

  • 815da99004a525241c437e0a19b6968e61e52fe5 from v8

Notes:

@ppontes ppontes added security 🔒 semver/patch backwards-compatible bug fixes backport-check-skip Skip trop's backport validity checking 32-x-y labels Feb 19, 2025
@ppontes ppontes requested a review from a team as a code owner February 19, 2025 22:51
@ckerr
Copy link
Member

ckerr commented Feb 20, 2025

Last CI run failed with something that looks unrelated to this PR; but it's an unusual error, so I'll paste it here before starting a new CI run:

FAILED: electron.exe electron.exe.pdb
....\third_party\llvm-build\Release+Asserts\bin\lld-link.exe "/OUT:./electron.exe" /nologo -libpath:....\third_party\llvm-build\Release+Asserts\lib\clang\19\lib\windows /winsysroot:../../third_party/depot_tools/win_toolchain/vs_files/3ba76c5c20 /MACHINE:X64 "/PDB:./electron.exe.pdb" "@./electron.exe.rsp"
lld-link: error: could not get the buffer for the member defining symbol public: __cdecl disk_cache::BlockFiles::BlockFiles(class base::FilePath const &): obj/net/net.lib(obj/net\net/block_files.obj): invalid argument

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
32-x-y backport-check-skip Skip trop's backport validity checking security 🔒 semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants