Add dependencies, cleanup readme and add installation on macos via homebrew #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 30, 2017 13:06
…fix discription of deprecated detection mode and move from code-snippets via indention to backticks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
thanks for your awesome work and the talk at the 34c3.
When I first tried to use your software on macos I realised there are some dependencies (
pygame,smpegto play the mp3 files andsdl_mixer) missing to actually get salamandra to work. And since I'm not using ports I added the homebrew part with these dependencies.While I was working on the readme I also did some other changes (use backticks instead of indention to add code snippets and and align the documentation of
Detection Modeto the actual command that is used there) to (in my opinion) enhance the readability a bit.Malte