-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix acceptance test assertions for updated plugin remove #17126
Merged
donoghuc
merged 1 commit into
elastic:main
from
donoghuc:update-acceptance-test-assertions-take-2
Feb 20, 2025
Merged
Fix acceptance test assertions for updated plugin remove #17126
donoghuc
merged 1 commit into
elastic:main
from
donoghuc:update-acceptance-test-assertions-take-2
Feb 20, 2025
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the acceptance tests to expect messages in the updated format for removing plugins. See elastic#17030 for change.
mashhurs
approved these changes
Feb 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
💚 Build Succeeded
|
@logstashmachine backport 9.0 |
@logstashmachine backport 8.x |
1 task
yaauie
pushed a commit
to yaauie/logstash
that referenced
this pull request
Feb 20, 2025
This commit updates the acceptance tests to expect messages in the updated format for removing plugins. See elastic#17030 for change.
donoghuc
added a commit
that referenced
this pull request
Feb 20, 2025
…7129) This commit updates the acceptance tests to expect messages in the updated format for removing plugins. See #17030 for change. (cherry picked from commit e8e24a0) Co-authored-by: Cas Donoghue <[email protected]>
This was referenced Feb 20, 2025
donoghuc
added a commit
that referenced
this pull request
Feb 20, 2025
…7131) This commit updates the acceptance tests to expect messages in the updated format for removing plugins. See #17030 for change. Co-authored-by: Cas Donoghue <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
[rn:skip]
What does this PR do?
This commit updates the acceptance tests to expect messages in the updated format for removing plugins. See #17030 for change.
Why is it important/What is the impact to the user?
No user impact, this is fixing acceptance test assertions
Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files (and/or docker env variables)- [ ] I have added tests that prove my fix is effective or that my feature worksRelated issues
remove
command to support multiple plugins #17030remove
#17122Logs
Example failures:
https://buildkite.com/elastic/logstash-exhaustive-tests-pipeline/builds/1361#01952103-6591-43cf-a364-cc876ac8bc21