Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix acceptance test assertions for updated plugin remove #17126

Merged

Conversation

donoghuc
Copy link
Member

Release notes

[rn:skip]

What does this PR do?

This commit updates the acceptance tests to expect messages in the updated format for removing plugins. See #17030 for change.

Why is it important/What is the impact to the user?

No user impact, this is fixing acceptance test assertions

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files (and/or docker env variables)
    - [ ] I have added tests that prove my fix is effective or that my feature works

Related issues

Logs

Example failures:
https://buildkite.com/elastic/logstash-exhaustive-tests-pipeline/builds/1361#01952103-6591-43cf-a364-cc876ac8bc21

Failures:
--
  |  
  | 1) CLI operation behaves like logstash remove logstash-plugin remove on [Ubuntu 20.04] when the plugin isn't installed fails to remove it
  | Failure/Error: DEFAULT_FAILURE_NOTIFIER = lambda { \|failure, _opts\| raise failure }
  |  
  | expected "ERROR: Operation aborted, cannot remove plugin, message: The plugin `logstash-filter-qatest` has not been previously installed" to match /This plugin has not been previously installed/
  | Diff:
  | @@ -1 +1 @@
  | -/This plugin has not been previously installed/
  | +"ERROR: Operation aborted, cannot remove plugin, message: The plugin `logstash-filter-qatest` has not been previously installed"
  |  
  | Shared Example Group: "logstash remove" called from ./acceptance/spec/lib/cli_operation_spec.rb:38
  | # ./acceptance/spec/shared_examples/cli/logstash-plugin/remove.rb:36:in `block in <main>'
  | # ./Rakefile:30:in `block in <main>'
  |  
  | Finished in 20 minutes 37 seconds (files took 1.57 seconds to load)
  | 30 examples, 1 failure, 1 pending

This commit updates the acceptance tests to expect messages in the updated
format for removing plugins. See elastic#17030
for change.
Copy link
Contributor

@mashhurs mashhurs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

@donoghuc donoghuc merged commit e8e24a0 into elastic:main Feb 20, 2025
7 checks passed
@donoghuc
Copy link
Member Author

@logstashmachine backport 9.0

@donoghuc
Copy link
Member Author

@logstashmachine backport 8.x

github-actions bot pushed a commit that referenced this pull request Feb 20, 2025
This commit updates the acceptance tests to expect messages in the updated
format for removing plugins. See #17030
for change.

(cherry picked from commit e8e24a0)
yaauie pushed a commit to yaauie/logstash that referenced this pull request Feb 20, 2025
This commit updates the acceptance tests to expect messages in the updated
format for removing plugins. See elastic#17030
for change.
donoghuc added a commit that referenced this pull request Feb 20, 2025
…7129)

This commit updates the acceptance tests to expect messages in the updated
format for removing plugins. See #17030
for change.

(cherry picked from commit e8e24a0)

Co-authored-by: Cas Donoghue <[email protected]>
donoghuc added a commit that referenced this pull request Feb 20, 2025
…7131)

This commit updates the acceptance tests to expect messages in the updated
format for removing plugins. See #17030
for change.

Co-authored-by: Cas Donoghue <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants