Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #17122 to 9.0: Fix acceptance test assertions for updated plugin remove #17123

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

github-actions[bot]
Copy link
Contributor

Backport PR #17122 to 9.0 branch, original message:


Release notes

[rn:skip]

What does this PR do?

This commit updates the acceptance tests to expect messages in the updated format for removing plugins. See #17030 for change.

Why is it important/What is the impact to the user?

No user impact, this is fixing acceptance test assertions

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files (and/or docker env variables)
    - [ ] I have added tests that prove my fix is effective or that my feature works

Related issues

Logs

Example failures:
https://buildkite.com/elastic/logstash-exhaustive-tests-pipeline/builds/1359#01951fe3-2f12-46d5-872e-0af111c463ba

1) CLI operation behaves like logstash uninstall logstash-plugin uninstall on [Ubuntu 22.04] when the plugin isn't installed fails to uninstall it
--
  | Failure/Error: DEFAULT_FAILURE_NOTIFIER = lambda { \|failure, _opts\| raise failure }
  |  
  | expected "ERROR: Operation aborted, cannot remove plugin, message: The plugin `logstash-filter-qatest` has not been previously installed" to match /This plugin has not been previously installed/
  | Diff:
  | @@ -1 +1 @@
  | -/This plugin has not been previously installed/
  | +"ERROR: Operation aborted, cannot remove plugin, message: The plugin `logstash-filter-qatest` has not been previously installed"
  |  
  | Shared Example Group: "logstash uninstall" called from ./acceptance/spec/lib/cli_operation_spec.rb:37
  | # ./acceptance/spec/shared_examples/cli/logstash-plugin/uninstall.rb:36:in `block in <main>'
  | # ./Rakefile:30:in `block in <main>'
  |  
  | 2) CLI operation behaves like logstash remove logstash-plugin remove on [Ubuntu 22.04] when the plugin isn't installed fails to remove it
  | Failure/Error: DEFAULT_FAILURE_NOTIFIER = lambda { \|failure, _opts\| raise failure }
  |  
  | expected "ERROR: Operation aborted, cannot remove plugin, message: The plugin `logstash-filter-qatest` has not been previously installed" to match /This plugin has not been previously installed/
  | Diff:
  | @@ -1 +1 @@
  | -/This plugin has not been previously installed/
  | +"ERROR: Operation aborted, cannot remove plugin, message: The plugin `logstash-filter-qatest` has not been previously installed"
  |  
  | Shared Example Group: "logstash remove" called from ./acceptance/spec/lib/cli_operation_spec.rb:38
  | # ./acceptance/spec/shared_examples/cli/logstash-plugin/remove.rb:36:in `block in <main>'
  | # ./Rakefile:30:in `block in <main>'
  |  
  | 3) CLI operation behaves like integration plugins compatible logstash-plugin uninstall on [Ubuntu 22.04] when the integration is installed trying to uninstall an inner plugin fails to uninstall it
  | Failure/Error: DEFAULT_FAILURE_NOTIFIER = lambda { \|failure, _opts\| raise failure }
  |  
  | expected "ERROR: Operation aborted, cannot remove plugin, message: The plugin `logstash-input-rabbitmq` is provided by 'logstash-integration-rabbitmq' so it can't be removed individually" to match /is already provided by/
  | Diff:
  | @@ -1 +1 @@
  | -/is already provided by/
  | +"ERROR: Operation aborted, cannot remove plugin, message: The plugin `logstash-input-rabbitmq` is provided by 'logstash-integration-rabbitmq' so it can't be removed individually"
  |  
  | Shared Example Group: "integration plugins compatible" called from ./acceptance/spec/lib/cli_operation_spec.rb:40
  | # ./acceptance/spec/shared_examples/cli/logstash-plugin/integration_plugin.rb:78:in `block in <main>'
  | # ./Rakefile:30:in `block in <main>'
  |  
  | Finished in 21 minutes 10 seconds (files took 1.68 seconds to load)
  | 30 examples, 3 failures, 1 pending

This commit updates the acceptance tests to expect messages in the updated
format for removing plugins. See #17030
for change.

(cherry picked from commit e094054)
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Copy link
Member

@yaauie yaauie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Clean and Green 🎉

@yaauie yaauie merged commit a86b0ce into 9.0 Feb 20, 2025
5 checks passed
@yaauie yaauie deleted the backport_17122_9.0 branch February 20, 2025 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants