-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix platform version #460
base: master
Are you sure you want to change the base?
Fix platform version #460
Conversation
ignore multigeiger.ino.cpp
set platform to ^3.5.0
please explain in the commit comments WHY the changes are needed. |
Using the PlatformIO example as is will currently use platform
instead of the required v1.0 ones I got from @rexfue:
|
it is still not clear to me what precisely the problem is. and aren't the library requirement defined by lib_deps? |
Nope, the sub dependencies Building with platform
|
Please merge! |
@shin10 "please explain in the commit comments WHY the changes are needed." You added some comments on github (above), but it would be better to have this in the git commit comments. So, can you please improve them (and c&p the explanation there)? Also, it is still unclear why the .gitignore change is needed, add an explanation to that commit, too, please. You can use |
Without this change the ESP32 is in a boot loop:
|
added multigeiger.ino.cpp to .gitignore
set platform to ^3.5.0 in platformio-example.ini