MEL metric for quality analysis

eclipse-agileuml · Jan 23, 2025 · b2504ed · b2504ed
1 parent a48d370
commit b2504ed
Show file tree

Hide file tree

Showing 29 changed files with 113 additions and 22 deletions.
diff --git a/AssertStatement.class b/AssertStatement.class
diff --git a/AssignStatement.class b/AssignStatement.class
diff --git a/BehaviouralFeature.class b/BehaviouralFeature.class
diff --git a/BehaviouralFeature.java b/BehaviouralFeature.java
@@ -7,7 +7,7 @@
 
 
 /******************************
-* Copyright (c) 2003--2024 Kevin Lano
+* Copyright (c) 2003--2025 Kevin Lano
 * This program and the accompanying materials are made available under the
 * terms of the Eclipse Public License 2.0 which is available at
 * http://www.eclipse.org/legal/epl-2.0
@@ -4421,6 +4421,7 @@ else if (useCase != null)
 
       int acomp = activity.syntacticComplexity(); 
       out.println("*** Activity syntactic complexity = " + acomp); 
+
       if (acomp > TestParameters.operationSizeLimit) 
       { System.err.println("!!! Code smell (EOS): too high activity complexity (" + acomp + ") for " + nme); 
         System.err.println(">>> Recommend refactoring by splitting operation"); 
@@ -4474,7 +4475,7 @@ public java.util.Map dataDependencies()
       Vector postvars = new Vector(); 
       postvars.add("result"); 
       Vector deps = activity.dataDependents(
-                       allvars,postvars);
+                                   allvars,postvars);
       System.out.println();  
       System.out.println(">***> result is derived from:\n  " + deps);
 

diff --git a/BinaryExpression.class b/BinaryExpression.class
diff --git a/BinaryExpression.java b/BinaryExpression.java
@@ -3,7 +3,7 @@
 import javax.swing.JOptionPane; 
 
 /******************************
-* Copyright (c) 2003--2024 Kevin Lano
+* Copyright (c) 2003--2025 Kevin Lano
 * This program and the accompanying materials are made available under the
 * terms of the Eclipse Public License 2.0 which is available at
 * http://www.eclipse.org/legal/epl-2.0
@@ -20658,6 +20658,13 @@ public Map energyUse(Map res, Vector rUses, Vector aUses)
     // are amber flags.
     // ->select(...)->any() is a red flag.  
 
+    int syn = syntacticComplexity(); 
+    if (syn > TestParameters.syntacticComplexityLimit)
+    { aUses.add("! Excessive expression size (MEL) in " + this + " : try to simplify OCL expression");
+      int ascore = (int) res.get("amber"); 
+      res.set("amber", ascore+1);
+    } 
+
     left.energyUse(res, rUses, aUses); 
     right.energyUse(res, rUses, aUses); 
 

diff --git a/BreakStatement.class b/BreakStatement.class
diff --git a/CaseStatement.class b/CaseStatement.class
diff --git a/CatchStatement.class b/CatchStatement.class
diff --git a/ConditionalExpression.class b/ConditionalExpression.class
diff --git a/ConditionalExpression.java b/ConditionalExpression.java
@@ -1,5 +1,5 @@
 /******************************
-* Copyright (c) 2003--2024 Kevin Lano
+* Copyright (c) 2003--2025 Kevin Lano
 * This program and the accompanying materials are made available under the
 * terms of the Eclipse Public License 2.0 which is available at
 * http://www.eclipse.org/legal/epl-2.0
@@ -183,7 +183,14 @@ public Expression simplifyOCL()
   } 
 
   public Map energyUse(Map res, Vector rUses, Vector oUses) 
-  { test.energyUse(res,rUses,oUses); 
+  { int syn = syntacticComplexity(); 
+    if (syn > TestParameters.syntacticComplexityLimit)
+    { oUses.add("! Excessive expression size (MEL) in " + this + " : try to simplify OCL expression");
+      int ascore = (int) res.get("amber"); 
+      res.set("amber", ascore+1);
+    } 
+
+    test.energyUse(res,rUses,oUses); 
     ifExp.energyUse(res,rUses,oUses); 
     elseExp.energyUse(res,rUses,oUses);
 

diff --git a/ConditionalStatement.class b/ConditionalStatement.class
diff --git a/ContinueStatement.class b/ContinueStatement.class
diff --git a/CreationStatement.class b/CreationStatement.class
diff --git a/Entity.java b/Entity.java
@@ -7,7 +7,7 @@
 
 
 /******************************
-* Copyright (c) 2003--2024 Kevin Lano
+* Copyright (c) 2003--2025 Kevin Lano
 * This program and the accompanying materials are made available under the
 * terms of the Eclipse Public License 2.0 which is available at
 * http://www.eclipse.org/legal/epl-2.0

diff --git a/ErrorStatement.class b/ErrorStatement.class
diff --git a/FinalStatement.class b/FinalStatement.class
diff --git a/IfCase.class b/IfCase.class
diff --git a/IfStatement.class b/IfStatement.class
diff --git a/ImplicitInvocationStatement.class b/ImplicitInvocationStatement.class
diff --git a/InvocationStatement.class b/InvocationStatement.class
diff --git a/ReturnStatement.class b/ReturnStatement.class
diff --git a/SequenceStatement.class b/SequenceStatement.class
diff --git a/Statement.java b/Statement.java
@@ -3,7 +3,7 @@
 import javax.swing.JOptionPane;
 
 /******************************
-* Copyright (c) 2003--2024 Kevin Lano
+* Copyright (c) 2003--2025 Kevin Lano
 * This program and the accompanying materials are made available under the
 * terms of the Eclipse Public License 2.0 which is available at
 * http://www.eclipse.org/legal/epl-2.0
@@ -2267,7 +2267,7 @@ else if (op != null)
   }
 
   public Map energyUse(Map uses, 
-                                Vector rUses, Vector oUses)
+                       Vector rUses, Vector oUses)
   { if (value == null) 
     { return uses; } 
     value.energyUse(uses, rUses, oUses); 
@@ -2569,7 +2569,15 @@ public Statement replaceModuleReferences(UseCase uc)
   public int syntacticComplexity()
   { if (value == null) 
     { return 1; } 
-    return value.syntacticComplexity() + 1; 
+
+    int syncomp = value.syntacticComplexity(); 
+
+    if (syncomp > TestParameters.syntacticComplexityLimit)
+    { System.err.println("!!! Code smell (MEL): too high expression complexity (" + syncomp + ") for " + value); 
+      System.err.println(">>> Recommend OCL refactoring"); 
+    } 
+
+    return syncomp + 1; 
   } 
 
   public int cyclomaticComplexity()
@@ -3921,7 +3929,14 @@ public Statement replaceModuleReferences(UseCase uc)
   public int syntacticComplexity()
   { if (callExp == null) 
     { return 1; } 
-    return callExp.syntacticComplexity() + 1; 
+
+    int syncomp = callExp.syntacticComplexity(); 
+    if (syncomp > TestParameters.syntacticComplexityLimit)
+    { System.err.println("!!! Code smell (MEL): too high expression complexity (" + syncomp + ") for " + callExp); 
+      System.err.println(">>> Recommend OCL refactoring"); 
+    } 
+
+    return syncomp + 1; 
   } 
 
   public int cyclomaticComplexity()
@@ -4374,7 +4389,14 @@ public Statement replaceModuleReferences(UseCase uc)
   public int syntacticComplexity()
   { if (callExp == null) 
     { return 1; } 
-    return callExp.syntacticComplexity() + 1; 
+
+    int syncomp = callExp.syntacticComplexity(); 
+    if (syncomp > TestParameters.syntacticComplexityLimit)
+    { System.err.println("!!! Code smell (MEL): too high expression complexity (" + syncomp + ") for " + callExp); 
+      System.err.println(">>> Recommend OCL refactoring"); 
+    } 
+
+    return syncomp + 1; 
   } 
 
   public int cyclomaticComplexity()
@@ -6282,14 +6304,27 @@ public int syntacticComplexity()
 
     if (loopKind == FOR) 
     { if (loopRange != null) 
-      { int rcomp = loopRange.syntacticComplexity(); 
+      { int rcomp = loopRange.syntacticComplexity();
+
+        if (rcomp > TestParameters.syntacticComplexityLimit)
+        { System.err.println("!!! Code smell (MEL): too high expression complexity (" + rcomp + ") for " + loopRange); 
+          System.err.println(">>> Recommend OCL refactoring"); 
+        } 
+
         return res + rcomp + 1; 
       } 
     } 
 
     if (loopTest == null) 
-    { return res + 1; } 
-    return loopTest.syntacticComplexity() + res + 1; 
+    { return res + 1; }
+
+    int syncomp = loopTest.syntacticComplexity(); 
+    if (syncomp > TestParameters.syntacticComplexityLimit)
+    { System.err.println("!!! Code smell (MEL): too high expression complexity (" + syncomp + ") for " + loopTest); 
+      System.err.println(">>> Recommend OCL refactoring"); 
+    } 
+
+    return syncomp + res + 1; 
   } 
 
   public int cyclomaticComplexity()
@@ -7707,7 +7742,17 @@ public Statement replaceModuleReferences(UseCase uc)
   { return this; } 
 
   public int syntacticComplexity()
-  { return 3; } // depends upon the type really. 
+  { if (initialExpression == null)
+    { return 3; } // depends upon the type really.
+
+    int syncomp = initialExpression.syntacticComplexity(); 
+    if (syncomp > TestParameters.syntacticComplexityLimit)
+    { System.err.println("!!! Code smell (MEL): too high expression complexity (" + syncomp + ") for " + initialExpression); 
+      System.err.println(">>> Recommend OCL refactoring");  
+    } 
+
+    return 3 + syncomp; 
+  } 
 
   public int cyclomaticComplexity()
   { return 0; } 
@@ -9838,7 +9883,14 @@ public Statement replaceModuleReferences(UseCase uc)
 
   public int syntacticComplexity()
   { if (thrownObject != null) 
-    { return 1 + thrownObject.syntacticComplexity(); } 
+    { int syncomp = thrownObject.syntacticComplexity(); 
+      if (syncomp > TestParameters.syntacticComplexityLimit)
+      { System.err.println("!!! Code smell (MEL): too high expression complexity (" + syncomp + ") for " + thrownObject); 
+        System.err.println(">>> Recommend OCL refactoring");  
+      } 
+      return 1 + syncomp; 
+    }
+
     return 1;
   } 
 
@@ -10235,7 +10287,13 @@ public Statement replaceModuleReferences(UseCase uc)
   { return this; } 
 
   public int syntacticComplexity()
-  { int res = condition.syntacticComplexity(); 
+  { int res = condition.syntacticComplexity();
+
+    if (res > TestParameters.syntacticComplexityLimit)
+    { System.err.println("!!! Code smell (MEL): too high expression complexity (" + res + ") for " + condition); 
+      System.err.println(">>> Recommend OCL refactoring");  
+    } 
+
     res++; 
     if (message != null) 
     { return res + message.syntacticComplexity(); } 
@@ -13581,7 +13639,13 @@ public Statement replaceModuleReferences(UseCase uc)
   }  
 
   public int syntacticComplexity()
-  { return lhs.syntacticComplexity() + rhs.syntacticComplexity() + 1; } 
+  { int syncomp = rhs.syntacticComplexity(); 
+    if (syncomp > TestParameters.syntacticComplexityLimit)
+    { System.err.println("!!! Code smell (MEL): too high expression complexity (" + syncomp + ") for " + rhs); 
+      System.err.println(">>> Recommend OCL refactoring");  
+    } 
+    return lhs.syntacticComplexity() + syncomp + 1; 
+  } 
 
   public int cyclomaticComplexity()
   { return 0; } 
@@ -13933,7 +13997,12 @@ public IfCase replaceModuleReferences(UseCase uc)
   } 
 
   public int syntacticComplexity()
-  { int res = test.syntacticComplexity(); 
+  { int res = test.syntacticComplexity();
+    if (res > TestParameters.syntacticComplexityLimit)
+    { System.err.println("!!! Code smell (MEL): too high expression complexity (" + res + ") for " + test); 
+      System.err.println(">>> Recommend OCL refactoring");  
+    } 
+
     res = res + ifPart.syntacticComplexity();
     return res + 1; 
   }
@@ -14755,6 +14824,12 @@ public Statement replaceModuleReferences(UseCase uc)
 
   public int syntacticComplexity()
   { int res = test.syntacticComplexity();
+
+    if (res > TestParameters.syntacticComplexityLimit)
+    { System.err.println("!!! Code smell (MEL): too high expression complexity (" + res + ") for " + test); 
+      System.err.println(">>> Recommend OCL refactoring");  
+    } 
+
     res = res + ifPart.syntacticComplexity(); 
     if (elsePart != null)
     { res = res + elsePart.syntacticComplexity(); }

diff --git a/TestParameters.class b/TestParameters.class
diff --git a/TestParameters.java b/TestParameters.java
@@ -1,6 +1,6 @@
 
 /******************************
-* Copyright (c) 2003--2024 Kevin Lano
+* Copyright (c) 2003--2025 Kevin Lano
 * This program and the accompanying materials are made available under the
 * terms of the Eclipse Public License 2.0 which is available at
 * http://www.eclipse.org/legal/epl-2.0
@@ -30,7 +30,8 @@ public class TestParameters
 
   /* Settings for flaw/technical debt detection */ 
 
-  public static int cloneSizeLimit = 6;
+  public static int syntacticComplexityLimit = 8; /* for MEL */ 
+  public static int cloneSizeLimit = 6;           /* for DC  */
   public static int statementNestingLimit = 5;  
   public static int cyclomaticComplexityLimit = 10; 
   public static int numberOfDataFeaturesLimit = 20; 

diff --git a/TryStatement.class b/TryStatement.class
diff --git a/UCDArea.java b/UCDArea.java
@@ -1,6 +1,6 @@
 
 /******************************
-* Copyright (c) 2003--2024 Kevin Lano
+* Copyright (c) 2003--2025 Kevin Lano
 * This program and the accompanying materials are made available under the
 * terms of the Eclipse Public License 2.0 which is available at
 * http://www.eclipse.org/legal/epl-2.0

diff --git a/WhileStatement.class b/WhileStatement.class