Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup Mode issue #48 #49

Merged
merged 5 commits into from
Feb 2, 2022
Merged

Setup Mode issue #48 #49

merged 5 commits into from
Feb 2, 2022

Conversation

nelsonic
Copy link
Member

This micro-PR is meant to help with the circular dependency issue. #48 see: dwyl/auth#170

@nelsonic nelsonic self-assigned this Jan 29, 2022
@codecov
Copy link

codecov bot commented Jan 29, 2022

Codecov Report

Merging #49 (0f1c215) into main (26ce3b4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #49   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines           82        82           
=========================================
  Hits            82        82           
Impacted Files Coverage Δ
lib/helpers.ex 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26ce3b4...0f1c215. Read the comment docs.

Copy link
Member

@SimonLab SimonLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 (sorry for the review delay, I forgot to check this notification again)

@SimonLab SimonLab merged commit b8fd28e into main Feb 2, 2022
@SimonLab SimonLab deleted the setup-mode-issue-#48 branch February 2, 2022 11:03
@nelsonic
Copy link
Member Author

nelsonic commented Feb 2, 2022

Merci @SimonLab 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants