Capped buffer expansion #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| } | ||
| catch(NotSupportedException e) | ||
| catch (NotSupportedException e) |
There was a problem hiding this comment.
may be we can now replace to some better exception? Like JoseException of subclass ?
|
@CrspyAu thanks. It looks good, one comment about exceptions and i need to run compatibility tests as usual before releasing. |
|
@CrspyAu looks good to me. Sorry little bit slow at the end of year. I'll fix CI issues and merge it. Guessing need to include new file in .sln or something along the lines. |
|
looks good now ) merging, will release somewhere after holidays. Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow memorystream to expand up to limit rather than pre-allocate max size for each call
#258