Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update image issues #108

Merged
merged 3 commits into from
Oct 18, 2024
Merged

update image issues #108

merged 3 commits into from
Oct 18, 2024

Conversation

kferrone
Copy link
Collaborator

Describe Changes

When updating an image and the image was the same as before two issues would occur:

  • last deployed by who and when did not get reported
  • the wait flag would cause an error because a certain value wasn't initialized properly.

Link to Issues

https://app.clickup.com/t/8655600/DUPLO-25663
https://app.clickup.com/t/8655600/DUPLO-25221

PR Review Checklist

  • Thoroughly reviewed on local machine.
  • Have you added any tests
  • Make sure to note changes in Changelog

@kferrone kferrone self-assigned this Oct 16, 2024
@duploctl
Copy link
Contributor

duploctl bot commented Oct 16, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
2197 442 20% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
src/duplo_resource/service.py 16% 🟢
TOTAL 16% 🟢

updated for commit: 35d659a by action🐍

@duplocloud-matt
Copy link
Contributor

I tested this and it does resolve the nonetype issue, but it does not update the deployment time as desired.

Copy link
Contributor

@duplocloud-matt duplocloud-matt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@kferrone kferrone merged commit aa86547 into main Oct 18, 2024
5 checks passed
@kferrone kferrone deleted the update-image-wait-fix branch October 18, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants