Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update integrations endpoint to v3 #38

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

ckeif-duo
Copy link
Contributor

This updates the only reference to /admin/v1/integrations to /admin/v3/integrations similar to duosecurity/duo_client_python#282. It also includes changes to update to canonicalization v5.

Description

Updates the /admin/v1/integrations reference to v3.

Because the v3 endpoints require canonicalization 5, the larger change in this PR is updating the canonicalization to 5.

Motivation and Context

The v3 integrations endpoints add a new user_access field and change the behavior of the groups_allowed field.

Previously the groups_allowed field by itself determined which users could authenticate with the application as described here. Now a third state has been added which allows no users to authenticate.

Because of that, the user_access field has been added to express this more cleanly, and groups_allowed can only be provided if user_access == "PERMITTED_GROUPS".

How Has This Been Tested?

  • Verified admin/v3/integrations endpoint is working as expected
  • Regression tested some old V1 endpoints (POST admin/v1/groups, POST admin/v1/groups/:gkey, POST admin/v1/users

https://gist.github.com/ckeif-duo/f86490d5380f6c57bfde4031e02e6795

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@AaronAtDuo AaronAtDuo merged commit 039279d into duosecurity:master Feb 19, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants