Authv2 / Networking improvements #3820
Open
+165
−85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -416,7 +415,7 @@ extension Pixel { | |||
| case networkProtectionTunnelFailureDetected | |||
| case networkProtectionTunnelFailureRecovered | |||
|
|
|||
| case networkProtectionLatency(quality: NetworkProtectionLatencyMonitor.ConnectionQuality) | |||
| case networkProtectionLatency(quality: String) | |||
There was a problem hiding this comment.
Changing just these allows us to remove NetworkProtection as dependency of Core and "flatten" the dependency tree, solving possible runtime issues during testing
There was a problem hiding this comment.
@diegoreymendez Do you have anything against this change? I can explain the rationale if needed.
# Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1205842942115003/1209170372758735/f
CC: @miasma13
Description:
Timport TestUtilsand replaced with the new dedicate test utils for each packageNetworkProtectionasCore.frameworkdependency and avoiding runtime issues during testing like:Steps to test this PR:
Internal references:
Software Engineering Expectations
Technical Design Template