iOS release flow automation #3818
Open
+699
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshann
changed the title
ayoy
reviewed
Jan 17, 2025
| - name: Set up fastlane | ||
| run: bundle install | ||
|
|
||
| - name: Prepare release bump #KS update is_scheduled_release |
There was a problem hiding this comment.
Is this comment still relevant?
Comment on lines
+43
to
+44
| with: | ||
| fetch-depth: 0 # Fetch all history and tags in order to extract Asana task URLs from git log |
There was a problem hiding this comment.
It seems to me that we can skip this in this job (I realize it was copied over from macOS where it's also not needed). Asana task URLs are only fetched in increment_build_number job below.
Comment on lines
+88
to
+99
| tag_and_merge: | ||
| name: Tag and Merge Branch | ||
| needs: [ create_release_branch, prepare_release ] | ||
| uses: ./.github/workflows/ios-tag-release.yml | ||
| with: | ||
| asana-task-url: ${{ needs.create_release_branch.outputs.asana_task_url }} | ||
| base-branch: ${{ github.ref_name }} | ||
| branch: ${{ needs.create_release_branch.outputs.release_branch_name }} | ||
| prerelease: true | ||
| secrets: | ||
| ASANA_ACCESS_TOKEN: ${{ secrets.ASANA_ACCESS_TOKEN }} | ||
| GHA_ELEVATED_PERMISSIONS_TOKEN: ${{ secrets.GHA_ELEVATED_PERMISSIONS_TOKEN }} |
There was a problem hiding this comment.
The one thing that Publish DMG Release workflow on macOS does for all releases is posting a comment to Asana saying that a new build is available for internal testing (listing tasks added since last internal release). Now I'm thinking that we should ideally call ios-tag-release-update-asana here (and restore "internal" release-type), instead of ios-tag-release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1205419239275955/1208056445209269/f
Tech Design URL:
CC:
Description:
Initial automation sharing for iOS release flow based on macOS release flow.
Steps to test this PR:
Definition of Done (Internal Only):
Copy Testing:
’rather than'Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template