Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename project file #3813

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Rename project file #3813

wants to merge 3 commits into from

Conversation

samsymons
Copy link
Contributor

@samsymons samsymons commented Jan 16, 2025

Task/Issue URL: https://app.asana.com/0/72649045549333/1209154396013377/f
Tech Design URL:
CC:

Description:

This PR renames the Xcode project file to DuckDuckGo-iOS.

Steps to test this PR:

  1. Check that CI is green
  2. Check that the project file opens and builds correctly
  3. Check that there are no remaining references to DuckDuckGo.xcodeproj
  4. Check that loc import and export works

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@samsymons samsymons marked this pull request as ready for review January 17, 2025 01:00
@samsymons samsymons requested a review from ayoy January 17, 2025 03:17
@samsymons
Copy link
Contributor Author

@ayoy I think this is ready - I'll defer merging it until Kieran's initial changes are merged though, the ETA of which is Friday. No big deal if this can't be looked at until next week tbh, there's no real rush on this.

The macOS branch is also ready but not open as a PR yet, I'll focus on getting this one merged first in case any surprised come up.

Copy link
Contributor

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, no DuckDuckGo.xcodeproj in sight and exporting localizations worked. The branch has conflicts that needs to be resolved so that would trigger the final CI run, if that's green then it's good to go. With the exception that Kieran's changes may only get to main on Monday...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants