Swiping tabs: Fix duplicate animations & edit mode detection #5481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0nko
commented
Jan 17, 2025
| tabRepository.flowTabs | ||
| .onEach { tabs -> | ||
| _viewState.update { | ||
| it.copy( | ||
| shouldUpdateTabsCount = tabs.count() != it.tabs.count() || tabs.isNotEmpty(), | ||
| tabs = tabs, | ||
| shouldUpdateTabsCount = tabs.size != it.tabCount && tabs.isNotEmpty(), |
There was a problem hiding this comment.
I think the original condition was wrong — we don’t ever want to show 0 (the initial ViewState value), because the actual count will always be at least 1.
0nko
commented
Jan 17, 2025
| @@ -99,7 +98,8 @@ class OmnibarLayoutViewModel @Inject constructor( | |||
| val updateOmnibarText: Boolean = false, | |||
| val shouldMoveCaretToEnd: Boolean = false, | |||
| val shouldMoveCaretToStart: Boolean = false, | |||
| val tabs: List<TabEntity> = emptyList(), | |||
There was a problem hiding this comment.
This list was only used to count the tabs. Each tab would contain a list of all these entities and with lots of tabs this would unnecessarily take up a lot of memory.
0nko
commented
Jan 17, 2025
| @@ -238,24 +246,30 @@ class OmnibarLayout @JvmOverloads constructor( | |||
| )[OmnibarLayoutViewModel::class.java] | |||
| } | |||
|
|
|||
| // One OmnibarLayout is always removed from the view hierarchy, we should cancel any flow subscriptions | |||
| fun onRemoved() { | |||
There was a problem hiding this comment.
Either the bottom or the top omnibar is always removed but its ViewModel flow subscriptions would keep collecting & rendering state for no reason.
0nko
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1207418217763355/1209152058231741/f
Description
This PR removes the onboarding restriction that prevents tab swiping until onboarding is complete. It also fixes a bug that shows duplicate omnibar highlight animations. The bug is caused due to RecyclerView calling the
View.onAttachedToWindow()every time the current item is changed, resulting in duplicatePulseAnimationinstances.The fix involves removing
PulseAnimationinitialization from theonAttachedToWindow()callback, so that it’s initialized only once.I also moved the injection to the constructor to avoid repeated injection calls and refactored the ViewModel flows collection to only happen during active lifecycle states.
While working on this, I discovered that edit mode wasn’t working properly and there’s a simpler way to do it, so I included it here.
Steps to test this PR