Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡️ Prebuilding arbitraries delays the time to import fast-check #5403

Closed
wants to merge 1 commit into from

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented Nov 2, 2024

Description

This PR replaces any part of the code that was responsible to pre-instantiate some arbitraries just in case it could be requested later.

ChecklistDon't delete this checklist and make sure you do the following before opening the PR

  • The name of my PR follows gitmoji specification
  • My PR references one of several related issues (if any)
    • New features or breaking changes must come with an associated Issue or Discussion
    • My PR does not add any new dependency without an associated Issue or Discussion
  • My PR includes bumps details, please run yarn bump and flag the impacts properly
  • My PR adds relevant tests and they would have failed without my PR (when applicable)

Advanced

  • Category: ...
  • Impacts: ...

This PR replaces any part of the code that was responsible to pre-instantiate some arbitraries just in case it could be requested later.
@dubzzz dubzzz added the 🧪 Experiment Performing some experiments for potential future features implying deep changes label Nov 2, 2024
Copy link

changeset-bot bot commented Nov 2, 2024

⚠️ No Changeset found

Latest commit: a1dd2a2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Nov 2, 2024

Open in Stackblitz@fast-check/examples

@fast-check/expect-type

yarn add https://pkg.pr.new/@fast-check/[email protected]

@fast-check/ava

yarn add https://pkg.pr.new/@fast-check/[email protected]

fast-check

yarn add https://pkg.pr.new/[email protected]

@fast-check/jest

yarn add https://pkg.pr.new/@fast-check/[email protected]

@fast-check/packaged

yarn add https://pkg.pr.new/@fast-check/[email protected]

@fast-check/poisoning

yarn add https://pkg.pr.new/@fast-check/[email protected]

@fast-check/vitest

yarn add https://pkg.pr.new/@fast-check/[email protected]

@fast-check/worker

yarn add https://pkg.pr.new/@fast-check/[email protected]

commit: a1dd2a2

Copy link
Contributor

github-actions bot commented Nov 2, 2024

👋 A preview of the new documentation is available at: http://6726a5549d11671f4f6544c2--dubzzz-fast-check.netlify.app

Copy link

codecov bot commented Nov 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.24%. Comparing base (e728907) to head (a1dd2a2).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5403   +/-   ##
=======================================
  Coverage   95.24%   95.24%           
=======================================
  Files         235      235           
  Lines       10583    10583           
  Branches     2826     2827    +1     
=======================================
  Hits        10080    10080           
  Misses        503      503           
Flag Coverage Δ
unit-tests 95.24% <100.00%> (ø)
unit-tests-18.x-Linux 95.24% <100.00%> (ø)
unit-tests-20.x-Linux 95.24% <100.00%> (ø)
unit-tests-22.x-Linux 95.24% <100.00%> (ø)
unit-tests-latest-Linux 95.24% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dubzzz dubzzz closed this Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧪 Experiment Performing some experiments for potential future features implying deep changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant