Skip to content

Commit

Permalink
chore(deps): update dependency esbuild to v0.18.19 (redwoodjs#8983)
Browse files Browse the repository at this point in the history
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [esbuild](https://togithub.com/evanw/esbuild) | [`0.18.16` ->
`0.18.19`](https://renovatebot.com/diffs/npm/esbuild/0.18.16/0.18.19) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/esbuild/0.18.19?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/esbuild/0.18.19?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/esbuild/0.18.16/0.18.19?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/esbuild/0.18.16/0.18.19?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>evanw/esbuild (esbuild)</summary>

###
[`v0.18.19`](https://togithub.com/evanw/esbuild/blob/HEAD/CHANGELOG.md#01819)

[Compare
Source](https://togithub.com/evanw/esbuild/compare/v0.18.18...v0.18.19)

- Implement `composes` from CSS modules
([#&redwoodjs#8203;20](https://togithub.com/evanw/esbuild/issues/20))

This release implements the `composes` annotation from the [CSS modules
specification](https://togithub.com/css-modules/css-modules#composition).
It provides a way for class selectors to reference other class selectors
(assuming you are using the `local-css` loader). And with the `from`
syntax, this can even work with local names across CSS files. For
example:

    ```js
    // app.js
    import { submit } from './style.css'
    const div = document.createElement('div')
    div.className = submit
    document.body.appendChild(div)
    ```

    ```css
    /* style.css */
    .button {
      composes: pulse from "anim.css";
      display: inline-block;
    }
    .submit {
      composes: button;
      font-weight: bold;
    }
    ```

    ```css
    /* anim.css */
    @&redwoodjs#8203;keyframes pulse {
      from, to { opacity: 1 }
      50% { opacity: 0.5 }
    }
    .pulse {
      animation: 2s ease-in-out infinite pulse;
    }
    ```

Bundling this with esbuild using `--bundle --outdir=dist
--loader:.css=local-css` now gives the following:

    ```js
    (() => {
      // style.css
      var submit = "anim_pulse style_button style_submit";

      // app.js
      var div = document.createElement("div");
      div.className = submit;
      document.body.appendChild(div);
    })();
    ```

    ```css
    /* anim.css */
    @&redwoodjs#8203;keyframes anim_pulse {
      from, to {
        opacity: 1;
      }
      50% {
        opacity: 0.5;
      }
    }
    .anim_pulse {
      animation: 2s ease-in-out infinite anim_pulse;
    }

    /* style.css */
    .style_button {
      display: inline-block;
    }
    .style_submit {
      font-weight: bold;
    }
    ```

Import paths in the `composes: ... from` syntax are resolved using the
new `composes-from` import kind, which can be intercepted by plugins
during import path resolution when bundling is enabled.

Note that the order in which composed CSS classes from separate files
appear in the bundled output file is deliberately ***undefined*** by
design (see [the
specification](https://togithub.com/css-modules/css-modules#composing-from-other-files)
for details). You are not supposed to declare the same CSS property in
two separate class selectors and then compose them together. You are
only supposed to compose CSS class selectors that declare
non-overlapping CSS properties.

Issue [#&redwoodjs#8203;20](https://togithub.com/evanw/esbuild/issues/20) (the
issue tracking CSS modules) is esbuild's most-upvoted issue! With this
change, I now consider esbuild's implementation of CSS modules to be
complete. There are still improvements to make and there may also be
bugs with the current implementation, but these can be tracked in
separate issues.

- Fix non-determinism with `tsconfig.json` and symlinks
([#&redwoodjs#8203;3284](https://togithub.com/evanw/esbuild/issues/3284))

This release fixes an issue that could cause esbuild to sometimes emit
incorrect build output in cases where a file under the effect of
`tsconfig.json` is inconsistently referenced through a symlink. It can
happen when using `npm link` to create a symlink within `node_modules`
to an unpublished package. The build result was non-deterministic
because esbuild runs module resolution in parallel and the result of the
`tsconfig.json` lookup depended on whether the import through the
symlink or not through the symlink was resolved first. This problem was
fixed by moving the `realpath` operation before the `tsconfig.json`
lookup.

- Add a `hash` property to output files
([#&redwoodjs#8203;3084](https://togithub.com/evanw/esbuild/issues/3084),
[#&redwoodjs#8203;3293](https://togithub.com/evanw/esbuild/issues/3293))

As a convenience, every output file in esbuild's API now includes a
`hash` property that is a hash of the `contents` field. This is the hash
that's used internally by esbuild to detect changes between builds for
esbuild's live-reload feature. You may also use it to detect changes
between your own builds if its properties are sufficient for your use
case.

This feature has been added directly to output file objects since it's
just a hash of the `contents` field, so it makes conceptual sense to
store it in the same location. Another benefit of putting it there
instead of including it as a part of the watch mode API is that it can
be used without watch mode enabled. You can use it to compare the output
of two independent builds that were done at different times.

The hash algorithm (currently [XXH64](https://xxhash.com/)) is
implementation-dependent and may be changed at any time in between
esbuild versions. If you don't like esbuild's choice of hash algorithm
then you are welcome to hash the contents yourself instead. As with any
hash algorithm, note that while two different hashes mean that the
contents are different, two equal hashes do not necessarily mean that
the contents are equal. You may still want to compare the contents in
addition to the hashes to detect with certainty when output files have
been changed.

- Avoid generating duplicate prefixed declarations in CSS
([#&redwoodjs#8203;3292](https://togithub.com/evanw/esbuild/issues/3292))

There was a request for esbuild's CSS prefixer to avoid generating a
prefixed declaration if a declaration by that name is already present in
the same rule block. So with this release, esbuild will now avoid doing
this:

    ```css
    /* Original code */
    body {
      backdrop-filter: blur(30px);
      -webkit-backdrop-filter: blur(45px);
    }

    /* Old output (with --target=safari12) */
    body {
      -webkit-backdrop-filter: blur(30px);
      backdrop-filter: blur(30px);
      -webkit-backdrop-filter: blur(45px);
    }

    /* New output (with --target=safari12) */
    body {
      backdrop-filter: blur(30px);
      -webkit-backdrop-filter: blur(45px);
    }
    ```

This can result in a visual difference in certain cases (for example if
the browser understands `blur(30px)` but not `blur(45px)`, it will be
able to fall back to `blur(30px)`). But this change means esbuild now
matches the behavior of [Autoprefixer](https://autoprefixer.github.io/)
which is probably a good representation of how people expect this
feature to work.

###
[`v0.18.18`](https://togithub.com/evanw/esbuild/blob/HEAD/CHANGELOG.md#01818)

[Compare
Source](https://togithub.com/evanw/esbuild/compare/v0.18.17...v0.18.18)

- Fix asset references with the `--line-limit` flag
([#&redwoodjs#8203;3286](https://togithub.com/evanw/esbuild/issues/3286))

The recently-released `--line-limit` flag tells esbuild to terminate
long lines after they pass this length limit. This includes
automatically wrapping long strings across multiple lines using escaped
newline syntax. However, using this could cause esbuild to generate
incorrect code for references from generated output files to assets in
the bundle (i.e. files loaded with the `file` or `copy` loaders). This
is because esbuild implements asset references internally using
find-and-replace with a randomly-generated string, but the find
operation fails if the string is split by an escaped newline due to line
wrapping. This release fixes the problem by not wrapping these strings.
This issue affected asset references in both JS and CSS files.

- Support local names in CSS for `@keyframe`, `@counter-style`, and
`@container`
([#&redwoodjs#8203;20](https://togithub.com/evanw/esbuild/issues/20))

This release extends support for local names in CSS files loaded with
the `local-css` loader to cover the `@keyframe`, `@counter-style`, and
`@container` rules (and also `animation`, `list-style`, and `container`
declarations). Here's an example:

    ```css
    @&redwoodjs#8203;keyframes pulse {
      from, to { opacity: 1 }
      50% { opacity: 0.5 }
    }
    @&redwoodjs#8203;counter-style moon {
      system: cyclic;
      symbols: 🌕 🌖 🌗 🌘 🌑 🌒 🌓 🌔;
    }
    @&redwoodjs#8203;container squish {
      li { float: left }
    }
    ul {
      animation: 2s ease-in-out infinite pulse;
      list-style: inside moon;
      container: squish / size;
    }
    ```

With the `local-css` loader enabled, that CSS will be turned into
something like this (with the local name mapping exposed to JS):

    ```css
    @&redwoodjs#8203;keyframes stdin_pulse {
      from, to {
        opacity: 1;
      }
      50% {
        opacity: 0.5;
      }
    }
    @&redwoodjs#8203;counter-style stdin_moon {
      system: cyclic;
      symbols: 🌕 🌖 🌗 🌘 🌑 🌒 🌓 🌔;
    }
    @&redwoodjs#8203;container stdin_squish {
      li {
        float: left;
      }
    }
    ul {
      animation: 2s ease-in-out infinite stdin_pulse;
      list-style: inside stdin_moon;
      container: stdin_squish / size;
    }
    ```

If you want to use a global name within a file loaded with the
`local-css` loader, you can use a `:global` selector to do that:

    ```css
    div {
      /* All symbols are global inside this scope (i.e.
       * "pulse", "moon", and "squish" are global below) */
      :global {
        animation: 2s ease-in-out infinite pulse;
        list-style: inside moon;
        container: squish / size;
      }
    }
    ```

If you want to use `@keyframes`, `@counter-style`, or `@container` with
a global name, make sure it's in a file that uses the `css` or
`global-css` loader instead of the `local-css` loader. For example, you
can configure `--loader:.module.css=local-css` so that the `local-css`
loader only applies to `*.module.css` files.

- Support strings as keyframe animation names in CSS
([#&redwoodjs#8203;2555](https://togithub.com/evanw/esbuild/issues/2555))

With this release, esbuild will now parse animation names that are
specified as strings and will convert them to identifiers. The CSS
specification allows animation names to be specified using either
identifiers or strings but Chrome only understands identifiers, so
esbuild will now always convert string names to identifier names for
Chrome compatibility:

    ```css
    /* Original code */
    @&redwoodjs#8203;keyframes "hide menu" {
      from { opacity: 1 }
      to { opacity: 0 }
    }
    menu.hide {
      animation: 0.5s ease-in-out "hide menu";
    }

    /* Old output */
@&redwoodjs#8203;keyframes "hide menu" { from { opacity: 1 } to { opacity: 0 } }
    menu.hide {
      animation: 0.5s ease-in-out "hide menu";
    }

    /* New output */
    @&redwoodjs#8203;keyframes hide\ menu {
      from {
        opacity: 1;
      }
      to {
        opacity: 0;
      }
    }
    menu.hide {
      animation: 0.5s ease-in-out hide\ menu;
    }
    ```

###
[`v0.18.17`](https://togithub.com/evanw/esbuild/blob/HEAD/CHANGELOG.md#01817)

[Compare
Source](https://togithub.com/evanw/esbuild/compare/v0.18.16...v0.18.17)

-   Support `An+B` syntax and `:nth-*()` pseudo-classes in CSS

This adds support for the `:nth-child()`, `:nth-last-child()`,
`:nth-of-type()`, and `:nth-last-of-type()` pseudo-classes to esbuild,
which has the following consequences:

- The [`An+B`
syntax](https://drafts.csswg.org/css-syntax-3/#anb-microsyntax) is now
parsed, so parse errors are now reported
- `An+B` values inside these pseudo-classes are now pretty-printed (e.g.
a leading `+` will be stripped because it's not in the AST)
- When minification is enabled, `An+B` values are reduced to equivalent
but shorter forms (e.g. `2n+0` => `2n`, `2n+1` => `odd`)
- Local CSS names in an `of` clause are now detected (e.g. in
`:nth-child(2n of :local(.foo))` the name `foo` is now renamed)

    ```css
    /* Original code */
    .foo:nth-child(+2n+1 of :local(.bar)) {
      color: red;
    }

    /* Old output (with --loader=local-css) */
    .stdin_foo:nth-child(+2n + 1 of :local(.bar)) {
      color: red;
    }

    /* New output (with --loader=local-css) */
    .stdin_foo:nth-child(2n+1 of .stdin_bar) {
      color: red;
    }
    ```

- Adjust CSS nesting parser for IE7 hacks
([#&redwoodjs#8203;3272](https://togithub.com/evanw/esbuild/issues/3272))

This fixes a regression with esbuild's treatment of IE7 hacks in CSS.
CSS nesting allows selectors to be used where declarations are expected.
There's an IE7 hack where prefixing a declaration with a `*` causes that
declaration to only be applied in IE7 due to a bug in IE7's CSS parser.
However, it's valid for nested CSS selectors to start with `*`. So
esbuild was incorrectly parsing these declarations and anything
following it up until the next `{` as a selector for a nested CSS rule.
This release changes esbuild's parser to terminate the parsing of
selectors for nested CSS rules when a `;` is encountered to fix this
edge case:

    ```css
    /* Original code */
    .item {
      *width: 100%;
      height: 1px;
    }

    /* Old output */
    .item {
      *width: 100%; height: 1px; {
      }
    }

    /* New output */
    .item {
      *width: 100%;
      height: 1px;
    }
    ```

Note that the syntax for CSS nesting is [about to change
again](https://togithub.com/w3c/csswg-drafts/issues/7961), so esbuild's
CSS parser may still not be completely accurate with how browsers do
and/or will interpret CSS nesting syntax. Expect additional updates to
esbuild's CSS parser in the future to deal with upcoming CSS
specification changes.

- Adjust esbuild's warning about undefined imports for TypeScript
`import` equals declarations
([#&redwoodjs#8203;3271](https://togithub.com/evanw/esbuild/issues/3271))

In JavaScript, accessing a missing property on an import namespace
object is supposed to result in a value of `undefined` at run-time
instead of an error at compile-time. This is something that esbuild
warns you about by default because doing this can indicate a bug with
your code. For example:

    ```js
    // app.js
    import * as styles from './styles'
    console.log(styles.buton)
    ```

    ```js
    // styles.js
    export let button = {}
    ```

    If you bundle `app.js` with esbuild you will get this:

▲ [WARNING] Import "buton" will always be undefined because there is no
matching export in "styles.js" [import-is-undefined]

            app.js:2:19:
              2 │ console.log(styles.buton)
                │                    ~~~~~
                ╵                    button

          Did you mean to import "button" instead?

            styles.js:1:11:
              1 │ export let button = {}
                ╵            ~~~~~~

However, there is TypeScript-only syntax for `import` equals
declarations that can represent either a type import (which esbuild
should ignore) or a value import (which esbuild should respect). Since
esbuild doesn't have a type system, it tries to only respect `import`
equals declarations that are actually used as values. Previously esbuild
always generated this warning for unused imports referenced within
`import` equals declarations even when the reference could be a type
instead of a value. Starting with this release, esbuild will now only
warn in this case if the import is actually used. Here is an example of
some code that no longer causes an incorrect warning:

    ```ts
    // app.ts
    import * as styles from './styles'
    import ButtonType = styles.Button
    ```

    ```ts
    // styles.ts
    export interface Button {}
    ```

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/redwoodjs/redwood).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4yNC4yIiwidXBkYXRlZEluVmVyIjoiMzYuMjcuMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
  • Loading branch information
renovate[bot] authored Aug 8, 2023
1 parent 5a07e63 commit 8e21a28
Show file tree
Hide file tree
Showing 12 changed files with 115 additions and 115 deletions.
2 changes: 1 addition & 1 deletion packages/cli-packages/storybook/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
},
"devDependencies": {
"@types/yargs": "17.0.24",
"esbuild": "0.18.16",
"esbuild": "0.18.19",
"fast-glob": "3.3.1",
"jest": "29.6.1",
"typescript": "5.1.6"
Expand Down
2 changes: 1 addition & 1 deletion packages/core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@
"css-loader": "6.8.1",
"css-minimizer-webpack-plugin": "5.0.1",
"dotenv-webpack": "8.0.1",
"esbuild": "0.18.16",
"esbuild": "0.18.19",
"fast-glob": "3.3.1",
"file-loader": "6.2.0",
"graphql": "16.7.1",
Expand Down
2 changes: 1 addition & 1 deletion packages/create-redwood-app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
"@babel/core": "7.22.9",
"@babel/plugin-transform-typescript": "7.22.9",
"@types/babel__core": "7.20.1",
"esbuild": "0.18.16",
"esbuild": "0.18.19",
"jest": "29.6.1",
"klaw-sync": "6.0.0"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/eslint-plugin/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"@types/eslint": "8",
"@types/estree": "1.0.1",
"@typescript-eslint/parser": "5.61.0",
"esbuild": "0.18.16",
"esbuild": "0.18.19",
"fast-glob": "3.3.1",
"glob": "10.3.1",
"typescript": "5.1.6"
Expand Down
2 changes: 1 addition & 1 deletion packages/fastify/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"@types/aws-lambda": "8.10.119",
"@types/lodash": "4.14.195",
"@types/qs": "6.9.7",
"esbuild": "0.18.16",
"esbuild": "0.18.19",
"typescript": "5.1.6"
},
"gitHead": "3905ed045508b861b495f8d5630d76c7a157d8f1"
Expand Down
2 changes: 1 addition & 1 deletion packages/internal/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
"chalk": "4.1.2",
"core-js": "3.31.1",
"deepmerge": "4.3.1",
"esbuild": "0.18.16",
"esbuild": "0.18.19",
"fast-glob": "3.3.1",
"fs-extra": "11.1.1",
"graphql": "16.7.1",
Expand Down
2 changes: 1 addition & 1 deletion packages/project-config/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"string-env-interpolation": "1.0.1"
},
"devDependencies": {
"esbuild": "0.18.16",
"esbuild": "0.18.19",
"jest": "29.6.1",
"rimraf": "5.0.1",
"typescript": "5.1.6"
Expand Down
2 changes: 1 addition & 1 deletion packages/realtime/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"@envelop/core": "4.0.0",
"@envelop/testing": "6.0.0",
"@envelop/types": "4.0.0",
"esbuild": "0.18.16",
"esbuild": "0.18.19",
"jest": "29.6.1",
"nodemon": "2.0.22",
"typescript": "5.1.6"
Expand Down
2 changes: 1 addition & 1 deletion packages/record/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"@babel/cli": "7.22.9",
"@babel/core": "7.22.9",
"@prisma/internals": "5.1.0",
"esbuild": "0.18.16",
"esbuild": "0.18.19",
"jest": "29.6.1"
},
"gitHead": "3905ed045508b861b495f8d5630d76c7a157d8f1"
Expand Down
2 changes: 1 addition & 1 deletion packages/tui/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"stdout-update": "1.6.8"
},
"devDependencies": {
"esbuild": "0.18.16",
"esbuild": "0.18.19",
"jest": "29.6.1",
"typescript": "5.1.6"
}
Expand Down
2 changes: 1 addition & 1 deletion packages/web-server/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
},
"devDependencies": {
"@types/yargs-parser": "21.0.0",
"esbuild": "0.18.16",
"esbuild": "0.18.19",
"typescript": "5.1.6"
},
"gitHead": "3905ed045508b861b495f8d5630d76c7a157d8f1"
Expand Down
Loading

0 comments on commit 8e21a28

Please sign in to comment.