Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow circle-basic in options.js - improved demo page #57

Merged
merged 3 commits into from
May 7, 2024

Conversation

alessiochiffi
Copy link
Contributor

Changes

  • Added 'circle-basic' to allowed options. It was missing from allowedStyle object in relation to outerStyle, resulting in an error in the console.
  • The style change from the dropdown is now immediate on the demo page, without the need of clicking try now.

@dshongphuc
Copy link
Owner

Hi @alessiochiffi thank you for your fix. But the "circle-basic" is outdated (and the ones from demo page are also outdated). Can you please remove it from allow options, and also change all "circle-basic" in the demo page to "circle" instead? Thanks

@alessiochiffi
Copy link
Contributor Author

That make sense, I removed circle-basic @dshongphuc 👍

@dshongphuc dshongphuc merged commit 0cb7d89 into dshongphuc:master May 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants