Silently fail on 'sites' directory not existing. #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When determining public file paths if the parent sites directory does not exist and exception is thrown which can break package command execution as well as initial installation (assuming config is defined prior to install). If the sites directory does not exist it is a safe assumption that the files directories do not exist either so silently failing and returning an empty array can be used safely and should not cause any other issues. Catch the base exception as Symfony finder can throw varying exceptions based on (assume) package versions. InvalidArgumentException as well as DirectoryNotFound exceptions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue links
#19