Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nydusify: fix the issue of blob not found when modifying image name d… #1667

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ymydb
Copy link

@ymydb ymydb commented Feb 19, 2025

Relevant Issue (if applicable)

If there are Issues related to this PullRequest, please list it.

Details

There are some bugs in nydusify commit image, following bugs are fixed in this:

  • commit image on rename repository
    Use the mount blob api in the same repository
    lQLPKIG8PDKZOFHNAezNBmqwAcplACLtsPsHkBC2zJLfAQ_1642_492
    lQLPJwJk2O5LQlHNAxnNAs-wrQYQz9DBey8Hj7GUCxDCAA_719_793
    image

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@ymydb ymydb requested a review from a team as a code owner February 19, 2025 14:34
@ymydb ymydb requested review from bergwolf, imeoer and Desiki-high and removed request for a team February 19, 2025 14:34
Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.41%. Comparing base (dd9ba54) to head (9f51b6c).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1667      +/-   ##
==========================================
- Coverage   60.42%   60.41%   -0.01%     
==========================================
  Files         146      146              
  Lines       48943    48943              
  Branches    46380    46380              
==========================================
- Hits        29573    29571       -2     
- Misses      17906    17907       +1     
- Partials     1464     1465       +1     

see 2 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant