Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add arithmetic #324

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

XIELongDragon
Copy link
Contributor

Add arithmetic supported, like

goqu.C("a").Add(1) // "a" + 1
goqu.C("a").Sub(-1).As("b") // ("a" - 1) AS "b"

@codecov
Copy link

codecov bot commented Feb 22, 2022

Codecov Report

Merging #324 (abd9a2e) into master (31d438d) will decrease coverage by 1.30%.
The diff coverage is 48.97%.

❗ Current head abd9a2e differs from pull request most recent head 30ad302. Consider uploading reports for the commit 30ad302 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #324      +/-   ##
==========================================
- Coverage   96.90%   95.59%   -1.31%     
==========================================
  Files          62       63       +1     
  Lines        3488     3586      +98     
==========================================
+ Hits         3380     3428      +48     
- Misses         92      142      +50     
  Partials       16       16              
Flag Coverage Δ
unittests 95.59% <48.97%> (-1.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
exp/bitwise.go 91.30% <0.00%> (-8.70%) ⬇️
exp/cast.go 89.74% <0.00%> (-10.26%) ⬇️
exp/func.go 90.00% <0.00%> (-10.00%) ⬇️
exp/arithmetic.go 21.27% <21.27%> (ø)
exp/exp.go 73.40% <90.00%> (+1.97%) ⬆️
exp/ident.go 100.00% <100.00%> (ø)
exp/literal.go 100.00% <100.00%> (ø)
sqlgen/expression_sql_generator.go 100.00% <100.00%> (ø)
sqlgen/sql_dialect_options.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31d438d...30ad302. Read the comment docs.

@XIELongDragon
Copy link
Contributor Author

@mattn @Frug can you help to take a look at this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant