Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Select statement has invalid NULL check syntax when using implicit nil value #272 #315

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

XIELongDragon
Copy link
Contributor

Select statement has invalid NULL check syntax when using implicit nil value #272

@codecov
Copy link

codecov bot commented Nov 23, 2021

Codecov Report

Merging #315 (2712bf5) into master (31d438d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #315   +/-   ##
=======================================
  Coverage   96.90%   96.91%           
=======================================
  Files          62       62           
  Lines        3488     3496    +8     
=======================================
+ Hits         3380     3388    +8     
  Misses         92       92           
  Partials       16       16           
Flag Coverage Δ
unittests 96.91% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
exp/bool.go 93.33% <100.00%> (ø)
internal/util/reflect.go 99.10% <100.00%> (+0.05%) ⬆️
sqlgen/expression_sql_generator.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31d438d...2712bf5. Read the comment docs.

@XIELongDragon
Copy link
Contributor Author

hi @mattn and @doug-martin any comments?

@nitaigao
Copy link

I just hit this, is there any update or workaround?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants