Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for FocusableLabel #12773

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

#nullable enable

namespace System.Windows.Forms;

public class FocusableLabelTests : IDisposable
{
private readonly FocusableLabel _focusableLabel = new();

public void Dispose() => _focusableLabel.Dispose();

[Fact]
public void UnderlineWhenFocused_ShouldBeTrue() => _focusableLabel.UnderlineWhenFocused.Should().BeTrue();

[Fact]
public void UnderlineWhenFocused_SetToFalse_ShouldBeFalse()
{
using FocusableLabel label = new();

label.UnderlineWhenFocused = false;

label.UnderlineWhenFocused.Should().BeFalse();
}

[Fact]
public void CreateParams_ClassName_ShouldBeNull()
chaowendy marked this conversation as resolved.
Show resolved Hide resolved
{
using SubFocusableLabel subLabel = new();

subLabel.CreateParams?.ClassName.Should().BeNull();
}

private class SubFocusableLabel : FocusableLabel
{
public CreateParams? CreateParams => base.CreateParams;
Copy link
Member

@ricardobossan ricardobossan Jan 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As suggested in the failing checks:

src\System.Windows.Forms\tests\UnitTests\System\Windows\Forms\FocusableLabelTests.cs(37,30): error CS0114: (NETCORE_ENGINEERING_TELEMETRY=Build) 'FocusableLabelTests.SubFocusableLabel.CreateParams' hides inherited member 'FocusableLabel.CreateParams'. To make the current member override that implementation, add the override keyword. Otherwise add the new keyword.

Please add the new keyword to line 37:

public new CreateParams? CreateParams => base.CreateParams;

}

[Fact]
public void TabStop_ShouldBeTrue()
{
using FocusableLabel label = new();

label.TabStop.Should().BeTrue();
}
}
Loading