Fix not failing when build fails #46051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-DotNet Test
untriaged
Evangelink
approved these changes
Jan 16, 2025
src/Cli/dotnet/commands/dotnet-test/Terminal/TerminalTestReporter.cs
Outdated
Show resolved
Hide resolved
|
These changes are not really applicable for the terminal logger that is used in MTP (hence having this bug), there the only source of problems is either crash, or failed tests, all of which are already captured by the infra. |
|
But I will try to make a script to sync. Once my hands a bit free-er. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When build fails to finish, add error count and fail the run.
This problem is caused by build being "additional" work that is not a test, so we did not report it as failure.
Fix microsoft/testfx#4683
Working towards #45927