Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dotnet-watch] Separate build from run #44699

Open
wants to merge 1 commit into
base: release/9.0.2xx
Choose a base branch
from

Conversation

tmat
Copy link
Member

@tmat tmat commented Nov 7, 2024

Update tests to use a recent Aspire package that does not require workload installation.

Use combination of dotnet build and dotnet run --no-build instead of dotnet run.
This has two benefits:

  • separates build output (only printed out to dotnet-watch console output on build error or in verbose mode) from application output (sent to Aspire console for Aspire resources)
  • when restarting subset of processes impacted by rude edit we can build all affected projects first and only when the build succeeds restart the processes.

Use regex to match errors and warnings in dotnet build output (dotnet build prints all output to stdout).

Fixes #44543

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch untriaged Request triage from a team member labels Nov 7, 2024
@tmat tmat changed the base branch from main to release/9.0.2xx November 7, 2024 02:05
Copy link
Contributor

Thanks for your PR, @tmat.
To learn about the PR process and branching schedule of this repo, please take a look at the SDK PR Guide.

@tmat tmat changed the title Separate build [dotnet-watch] Separate build from run Nov 12, 2024
@tmat tmat marked this pull request as ready for review November 12, 2024 00:35
@tmat tmat requested a review from a team as a code owner November 12, 2024 00:35
@tmat
Copy link
Member Author

tmat commented Nov 12, 2024

@phil-allen-msft ptal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant