-
-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add analyzer RCS0062, put expression body on its own line (#1575) #1593
Add analyzer RCS0062, put expression body on its own line (#1575) #1593
Conversation
@dotnet-policy-service agree |
src/Tests/Formatting.Analyzers.Tests/RCS0062PutExpressionBodyOnItsOwnLineTests.cs
Outdated
Show resolved
Hide resolved
89144ec
to
736c1a7
Compare
@josefpihrt So now I tried to add bool option I decided to go with the bool option instead of adding a third value for the |
3fc981e
to
d016f62
Compare
d016f62
to
cd2e100
Compare
src/Workspaces.Common/CSharp/Refactorings/ConvertBlockBodyToExpressionBodyRefactoring.cs
Outdated
Show resolved
Hide resolved
src/Workspaces.Common/CSharp/Refactorings/ConvertBlockBodyToExpressionBodyRefactoring.cs
Outdated
Show resolved
Hide resolved
@josefpihrt Thanks for the fixes, hopefully I'll get into the coding conventions quickly. |
@cbersch please update changelog |
@josefpihrt Added to changelog |
…pressionBodyRefactoring.cs
…pressionBodyRefactoring.cs
c44c0f6
to
9e9ab86
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking really good. I added some final comments and then we are good to go.
@cbersch Great job! I think you were one of the first (if not the first) contributor to implement a new analyzer (including the code fix). Thanks! |
@josefpihrt Thanks for your support, I'm happy to contribute. |
Fixes #1575
Add new analyzer to put an existing expression body on its own line.