Skip to content

Commit

Permalink
PR feedback.
Browse files Browse the repository at this point in the history
  • Loading branch information
JoeRobich committed May 1, 2024
1 parent 8d138d9 commit e42f3d8
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 14 deletions.
13 changes: 7 additions & 6 deletions eng/Publishing.props
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,15 @@
<PublishDependsOnTargets>_ResolvePublishRoslynNuGetPackages;$(PublishDependsOnTargets)</PublishDependsOnTargets>
</PropertyGroup>

<!--
During PR Validation we only need to publish symbols with Arcade,
since our packages are published separately to the CoreXT feed.
-->
<Target Name="_ResolvePublishRoslynNuGetPackages"
DependsOnTargets="BeforePublish"
BeforeTargets="PublishToAzureDevOpsArtifacts">
<!--
During PR Validation we only need to publish symbols with Arcade,
since our packages are published separately to the CoreXT feed.
-->
<ItemGroup Condition=" '$(PreReleaseVersionLabel)' == 'pr-validation' ">
BeforeTargets="PublishToAzureDevOpsArtifacts"
Condition=" '$(PreReleaseVersionLabel)' == 'pr-validation' ">
<ItemGroup>
<!-- Determine all NuGet packages being published -->
<_NuGetPackagesToPush Include="@(ItemsToPushToBlobFeed)"
Condition=" '%(Extension)' == '.nupkg' " />
Expand Down
5 changes: 0 additions & 5 deletions eng/SymbolPublishingExclusionsFile.txt
Original file line number Diff line number Diff line change
@@ -1,10 +1,5 @@
content/LanguageServer/alpine-arm64/libe_sqlite3.so
content/LanguageServer/alpine-x64/libe_sqlite3.so
content/LanguageServer/linux-musl-arm64/libe_sqlite3.so
content/LanguageServer/linux-musl-x64/libe_sqlite3.so
content/LanguageServer/neutral/runtimes/alpine-arm64/native/libe_sqlite3.so
content/LanguageServer/neutral/runtimes/alpine-arm/native/libe_sqlite3.so
content/LanguageServer/neutral/runtimes/alpine-x64/native/libe_sqlite3.so
content/LanguageServer/neutral/runtimes/linux-musl-arm64/native/libe_sqlite3.so
content/LanguageServer/neutral/runtimes/linux-musl-arm/native/libe_sqlite3.so
content/LanguageServer/neutral/runtimes/linux-musl-x64/native/libe_sqlite3.so
3 changes: 0 additions & 3 deletions eng/build.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -260,8 +260,6 @@ function BuildSolution() {

$restoreUseStaticGraphEvaluation = $true

$symbolPublishingExcludeFile = Join-Path $RepoRoot "eng\SymbolPublishingExclusionsFile.txt"

try {
MSBuild $toolsetBuildProj `
$bl `
Expand All @@ -284,7 +282,6 @@ function BuildSolution() {
/p:RestoreUseStaticGraphEvaluation=$restoreUseStaticGraphEvaluation `
/p:VisualStudioIbcDrop=$ibcDropName `
/p:VisualStudioDropAccessToken=$officialVisualStudioDropAccessToken `
/p:SymbolPublishingExclusionsFile=$symbolPublishingExcludeFile `
$suppressExtensionDeployment `
$msbuildWarnAsError `
$buildFromSource `
Expand Down

0 comments on commit e42f3d8

Please sign in to comment.