Skip to content

Commit

Permalink
Revert "Change PR Val builds to be unsigned (#76358)"
Browse files Browse the repository at this point in the history
This reverts commit 2eca5b2, reversing
changes made to fe3a243.
  • Loading branch information
dibarbet committed Jan 22, 2025
1 parent 9cab90a commit e0a72d0
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 17 deletions.
2 changes: 0 additions & 2 deletions azure-pipelines-pr-validation.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,6 @@ variables:
value: false
- name: Codeql.SkipTaskAutoInjection
value: true
- name: SignType
value: ''

# To retrieve OptProf data we need to authenticate to the VS drop storage.
# If the pipeline is running in DevDiv, the account has access to the VS drop storage.
Expand Down
15 changes: 0 additions & 15 deletions eng/Signing.props
Original file line number Diff line number Diff line change
Expand Up @@ -61,19 +61,4 @@
<FileSignInfo Include="Microsoft.VisualStudio.Threading.dll" CertificateName="MicrosoftSHA2" />
<FileSignInfo Include="StreamJsonRpc.dll" CertificateName="MicrosoftSHA2" />
</ItemGroup>

<!--
We do not intend to ship the artifacts produced for PR validation build so we can skip signing the artifacts.
-->
<Choose>
<When Condition="'$(PreReleaseVersionLabel)' == 'pr-validation' And '$(SignType)' == ''">
<ItemGroup>
<ItemsToSign Remove="@(ItemsToSign)" />
</ItemGroup>

<PropertyGroup>
<AllowEmptySignList>true</AllowEmptySignList>
</PropertyGroup>
</When>
</Choose>
</Project>

0 comments on commit e0a72d0

Please sign in to comment.