Fix PowerShell Script Issues (#76219)

Ran into issues running PowerShell script issues tonight looking at determinism. After digging down discovered that our scripts didn't run correctly when launching the .cmd files from a pwsh shell. Changed our cmd to avoid this problem.

PowerShell/PowerShell#24630

docs/contributing/Powershell Guidelines.md

@@ -106,3 +106,22 @@ in source and unified build. Until that moves to `pwsh` our scripts need to stay
 
 The exception is that our VS Code helper scripts should use `pwsh`. That is not a part of our 
 infrastructure and needs to run cross platform hence `pwsh` is appropriate.
+
+### Supporting .cmd file
+
+Consider adding a `.cmd` file that calls the `.ps1` file. This is to support users who are not 
+running a powershell shell. It also helps with ensuring the script is run locally the same it is 
+run in CI by controlling the powershell used to invoke the script.
+
+test.cmd
+
+```cmd
+@echo off
+set PSMODULEPATH=
+powershell -noprofile -ExecutionPolicy Unrestricted -file "%~dp0\test.ps1" %*
+```
+
+Note: the `PSMODULEPATH` is cleared to ensure a pwsh shell [does not interfere][psmodulepath] 
+with launching powershell.
+
+[psmodulepath]: https://github.com/PowerShell/PowerShell/discussions/24630

eng/generate-compiler-code.cmd

@@ -1,3 +1,4 @@
 @echo off
-powershell -noprofile -executionPolicy RemoteSigned -file "%~dp0\generate-compiler-code.ps1" %* 
+set PSMODULEPATH=
+powershell -noprofile -executionPolicy Unrestricted -file "%~dp0\generate-compiler-code.ps1" %* 
 

eng/make-bootstrap.cmd

@@ -1,2 +1,3 @@
 @echo off
-powershell -noprofile -file "%~dp0\make-bootstrap.ps1" %* 
+set PSMODULEPATH=
+powershell -noprofile -executionPolicy Unrestricted -file "%~dp0\make-bootstrap.ps1" %* 

eng/make-bootstrap.ps1

@@ -46,6 +46,8 @@ try {
     throw "Unsupported bootstrap toolset $toolset"
   }
 
+  $projectPath = Join-Path $RepoRoot $projectPath
+
   $name = Split-Path -Leaf $output
   $binaryLogFilePath = Join-Path $LogDir "bootstrap-$($name).binlog"
 

eng/test-build-correctness.cmd

@@ -1,2 +1,3 @@
 @echo off
-powershell -noprofile -file "%~dp0\test-build-correctness.ps1" %*
+set PSMODULEPATH=
+powershell -noprofile -executionPolicy Unrestricted -file "%~dp0\test-build-correctness.ps1" %*

eng/test-determinism.cmd

@@ -1,2 +1,3 @@
 @echo off
-powershell -noprofile -file "%~dp0\test-determinism.ps1" %*
+set PSMODULEPATH=
+powershell -noprofile -executionPolicy Unrestricted -file "%~dp0\test-determinism.ps1" %*

eng/test-determinism.ps1

@@ -67,6 +67,7 @@ function Run-Build([string]$rootDir, [string]$logFileName) {
      /p:RepoRoot=$rootDir `
      /p:TreatWarningsAsErrors=true `
      /p:BootstrapBuildPath=$bootstrapDir `
+     /p:DeterministicSourcePaths=true `
      /p:RunAnalyzers=false `
      /p:RunAnalyzersDuringBuild=false `
      /p:RestoreUseStaticGraphEvaluation=$restoreUseStaticGraphEvaluation `
@@ -286,8 +287,8 @@ try {
 
   if ($bootstrapDir -eq "") {
     Write-Host "Building bootstrap compiler"
-    $bootstrapDir = Join-Path $ArtifactsDir "bootstrap" "determinism"
-    & eng/make-bootstrap.ps1 -output $bootstrapDir -ci:$ci
+    $bootstrapDir = Join-Path $ArtifactsDir (Join-Path "bootstrap" "determinism")
+    & eng/make-bootstrap.ps1 -output $bootstrapDir -ci:$ci -force
     Test-LastExitCode
   }
 

eng/test-rebuild.cmd

@@ -1,2 +1,3 @@
 @echo off
+set PSMODULEPATH=
 powershell -noprofile -file "%~dp0\test-rebuild.ps1" %*