[7.x] Avoid resending unchanged ClusterManifest to clients #8772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, we will release a local version to test the issue has been fixed. |
|
Great, thank you @HermesNew |
|
@ReubenBond I have push a pr to branch 7.x . |
|
After testing, the issue with #8722 has been fixed. |
|
@HermesNew I cherry-picked your commit onto this PR since it has not been merged yet. I'll close #8778. |
…test version (dotnet#8728) Co-authored-by: Reuben Bond <[email protected]> Co-authored-by: ReubenBond <[email protected]> Co-authored-by: HermesNew <[email protected]>
ReubenBond
force-pushed
the
v7/client-cluster-manifest-dedupe
branch
from
39f12a5 to
b0f8d25
Compare
|
Ok, that's right.Hope to release the version as soon as possible. |
|
We should be able to release a new version next week |
|
@ReubenBond I have push a pr #8782 |
There was no newer cluster manifest, so wait for the next refresh interval and try again.
|
Thank you @HermesNew - I should not have removed that part. I've incorporated your change into this PR and have added some feedback on top |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #8728
cc @453873 @HermesNew if you want a 7.x version of the PR to try, try this one
Microsoft Reviewers: Open in CodeFlow