Nullable DatePicker (make Date, MinimumDate & MaximumDate nullable) #27921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfversluis
added
t/breaking 💥
area-controls-datetimepicker
|
🚨 API change(s) detected @davidbritch FYI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The long awaited feature of making the
Date,MinimumDate, andMaximumDateproperties of theDatePickerclass nullable has been implemented!Changes
DateTime DatePicker.Date->DateTime? DatePicker.DateDateTime DatePicker.MaximumDate->DateTime? DatePicker.MaximumDateDateTime DatePicker.MinimumDate->DateTime? DatePicker.MinimumDateIn #1100 it is proposed to also make the type
DateOnly, while I like that, unfortunately that type is not available in netstandard so that would cause a lot of duplication of code and not great APIs and might even just be impossible because of that to make the XAML parsing and design time tooling work.Instead, I think we should take #21989 in addition to this to still allow people to use
DateOnly(andTimeOnly).Issues Fixed
Contributes to #1100 (
TimePickerPR in #27930)