Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New auth best practices doc #44284

Merged
merged 23 commits into from
Jan 17, 2025
Merged

New auth best practices doc #44284

merged 23 commits into from
Jan 17, 2025

Conversation

alexwolfmsft
Copy link
Contributor

@alexwolfmsft alexwolfmsft commented Jan 14, 2025 •
edited by github-actions bot
Loading

Summary

Describe your changes here.

Fixes #Issue_Number (if available)

Internal previews

📄 File 🔗 Preview link
docs/azure/sdk/authentication/authentication-best-practices.md Authentication best practices with the Azure Identity library for .NET
docs/azure/TOC.yml docs/azure/TOC

@dotnetrepoman dotnetrepoman bot added this to the January 2025 milestone Jan 14, 2025
@alexwolfmsft @christothes
Apply suggestions from code review
9c4c531 
Co-authored-by: Christopher Scott <[email protected]>
@alexwolfmsft alexwolfmsft marked this pull request as ready for review January 15, 2025 21:18
@alexwolfmsft alexwolfmsft requested review from schaabs, CamSoper, a team and jsquire as code owners January 15, 2025 21:18
christothes
christothes approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@christothes christothes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple minor suggestions, but overall LGTM!

scottaddie
scottaddie approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@scottaddie scottaddie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after incorporating Chris' suggestions!

@alexwolfmsft @christothes
Apply suggestions from code review
6ab8d70 
Co-authored-by: Christopher Scott <[email protected]>
@alexwolfmsft alexwolfmsft merged commit 1c007f0 into dotnet:main Jan 17, 2025
8 checks passed
@scottaddie scottaddie mentioned this pull request Jan 17, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottaddie scottaddie scottaddie approved these changes

@christothes christothes christothes approved these changes

@schaabs schaabs Awaiting requested review from schaabs schaabs is a code owner

@CamSoper CamSoper Awaiting requested review from CamSoper CamSoper is a code owner

@jsquire jsquire Awaiting requested review from jsquire jsquire is a code owner

Assignees
No one assigned
Labels
dotnet-azure/svc
Projects
None yet
Milestone
January 2025
Development

Successfully merging this pull request may close these issues.
3 participants
@alexwolfmsft @christothes @scottaddie