Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK breaking changes #43371

Merged
merged 1 commit into from
Nov 11, 2024
Merged

SDK breaking changes #43371

merged 1 commit into from
Nov 11, 2024

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Nov 7, 2024 •
edited by github-actions bot
Loading

@gewarren gewarren requested review from tdykstra and a team as code owners November 7, 2024 00:07
@dotnetrepoman dotnetrepoman bot added this to the November 2024 milestone Nov 7, 2024
@gewarren gewarren requested review from marcpopMSFT and a team and removed request for a team and tdykstra November 7, 2024 00:07
BillWagner
BillWagner approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @gewarren

Let's :shipit:

@gewarren gewarren merged commit e7999d4 into dotnet:main Nov 11, 2024
11 checks passed
@gewarren gewarren deleted the sdk-gc-9 branch November 11, 2024 18:53
@gewarren
Copy link
Contributor Author

Thanks @BillWagner!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

@marcpopMSFT marcpopMSFT Awaiting requested review from marcpopMSFT

Assignees
No one assigned
Labels
dotnet-cli/subsvc dotnet-fundamentals/svc
Projects
None yet
Milestone
November 2024
2 participants
@gewarren @BillWagner