Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix System.Text.Json converter documentation: Converters is a readonly property #43179

Closed
wants to merge 0 commits into from

Conversation

SeppPenner
Copy link

Summary

Changed the code samples with System.Text.Json Converters (Now readonly property).

Fixes #43178.

--> No idea why the renaming of the localizer is in there (Is already merged)...

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates PR is created by someone from the .NET community. label Oct 23, 2024
@gewarren
Copy link
Contributor

gewarren commented Oct 23, 2024

--> No idea why the renaming of the localizer is in there (Is already merged)...

@SeppPenner That's because you're submitting PRs from your main branch. I'd recommend following this guidance (but replace master with main): https://gist.github.com/billbonney/76de0f1a2e79f3a8a1a5. After you reset your main branch, create a working branch off of main and cherry pick the two commits that you actually want from this PR. And then create a new PR.

@SeppPenner SeppPenner closed this Nov 5, 2024
SeppPenner added a commit to SeppPenner/docs that referenced this pull request Nov 5, 2024
Changed the code samples with System.Text.Json Converters (Now readonly property).

Fixes dotnet#43178, makes dotnet#43179 obsolete.
@SeppPenner
Copy link
Author

Superseeded by #43349.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution Indicates PR is created by someone from the .NET community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

System.Text.Json converter documentation: Converters is a readonly property
2 participants